Fix overbright bugs - #1404
Merged
Merged
Conversation
It fixes the glass_02 door in perseus map. The code was slightly rewritten too.
…stead of doing it per-texture It fixes rendering fullbright lightmap stages when light mode is not fullbright, like the starchart512 hologram in procyon map.
illwieckz
force-pushed
the
illwieckz/obb
branch
from
October 30, 2024 07:05
023d755 to
7d43bc4
Compare
Member
Author
|
Perseus:
Procyon:
|
illwieckz
force-pushed
the
illwieckz/obb
branch
from
October 30, 2024 07:17
7d43bc4 to
558b791
Compare
illwieckz
force-pushed
the
illwieckz/obb
branch
4 times, most recently
from
October 30, 2024 07:26
1559cbc to
a4b6a8a
Compare
VReaperV
reviewed
Oct 30, 2024
Member
|
Thoughts on #1406? |
Member
Author
To be investigated after 0.55.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderer: cancel overbright on added lightmapIt fixes the perseus glass_02 door.
The code was slightly rewritten too.
renderer: disable GLSL overbright on fullbright lightmode globally instead of doing it per-textureIt fixes rendering fullbright lightmap stages when light mode is not fullbright,
like the starchart512 hologram in procyon map.
Fix Unvanquished/Unvanquished#3161 and #1405: