Fix backEnd.currentVAO - #1513
Merged
Merged
Conversation
Member
|
Is it even used for anything? |
Contributor
Author
Yeah, a VAO is required for any vertex specification commands (and by extension the typical rendering commands). |
This was previously getting reset in `R_Init()`, so it was always 0 after a map was loaded. This also meant that the call to `glDeleteVertexArrays()` in `RE_Shutdown()` was silently erroring out if a map was loaded (or `vid_restart` used).
VReaperV
force-pushed
the
fix-current-vao
branch
from
January 22, 2025 22:28
5d14043 to
f7abc30
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously getting reset in
R_Init(), so it was always 0 after a map was loaded. This also meant that the call toglDeleteVertexArrays()inRE_Shutdown()was silently erroring out if a map was loaded (orvid_restartused).