Fix cursor not rendering right in main menu - #1592
Merged
Merged
Conversation
Some 2D shaders are automatically assigned CGEN_IDENTITY_LIGHTING. This causes a bug of the cursor being black in the main menu (where tr.identityLighting is 0) and the wrong color if r_overbrightQ3 is used while in a map. Fix by making it behave as CGEN_IDENTITY during 2D rendering. Fixes DaemonEngine#1590.
VReaperV
approved these changes
Mar 11, 2025
VReaperV
left a comment
VReaperV
left a comment
Contributor
There was a problem hiding this comment.
That fixes the issue on my end. LGTM.
There's an up-to-date one in R_InitImages().
Member
Author
|
Added a 2nd commit that cleans up another outdated comment about overbright. |
VReaperV
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some 2D shaders are automatically assigned CGEN_IDENTITY_LIGHTING. This causes a bug of the cursor being black in the main menu (where tr.identityLighting is 0) and the wrong color if r_overbrightQ3 is used while in a map. Fix by making it behave as CGEN_IDENTITY during 2D rendering.
Fixes #1590.