PushBuffer auxiliary changes - #1683
Merged
Merged
Conversation
VReaperV
force-pushed
the
push-buffer-aux
branch
from
June 23, 2025 11:01
b797a4d to
05ea682
Compare
Merged
VReaperV
force-pushed
the
push-buffer-aux
branch
from
June 24, 2025 07:00
05ea682 to
28210b6
Compare
Contributor
Author
|
Also moved |
VReaperV
force-pushed
the
push-buffer-aux
branch
from
June 25, 2025 06:07
3f4e4cd to
4726cd1
Compare
This will be required for PushBuffer.
Will be required for PushBuffer. Also added back `_isTexture` to `GLUniform` because it will also be needed for PushBuffer.
Needed for `PushBuffer`.
…stem Deleting the buffer automatically unmaps it.
VReaperV
force-pushed
the
push-buffer-aux
branch
from
June 28, 2025 13:20
4726cd1 to
612d023
Compare
slipher
reviewed
Jul 8, 2025
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1682
More changes cherry-picked from
PushBufferimplementation, in a different pr to make the mainPushBufferpr lighter.