Skip to content

Renderer: Avoid a DSA function with VAOs - #1733

Merged
illwieckz merged 1 commit into
DaemonEngine:masterfrom
slipher:vao-no-dsa
Aug 11, 2025
Merged

Renderer: Avoid a DSA function with VAOs#1733
illwieckz merged 1 commit into
DaemonEngine:masterfrom
slipher:vao-no-dsa

Conversation

@slipher

@slipher slipher commented Aug 6, 2025

Copy link
Copy Markdown
Member

Use the old method to bind the IBO to the VAO instead of glVertexArrayElementBuffer. Fixes #1729.

Use the old method to bind the IBO to the VAO instead of
glVertexArrayElementBuffer. Fixes DaemonEngine#1729.
@illwieckz

Copy link
Copy Markdown
Member

Is it the same but with a different syntax? Or can glVertexArrayElementBuffer() be faster when available?

@slipher

slipher commented Aug 6, 2025

Copy link
Copy Markdown
Member Author

Is it the same but with a different syntax?

Yes

@illwieckz

Copy link
Copy Markdown
Member

In which situation the remaining glVertexArrayElementBuffer() call can happen? It seems to be used in some GeometryCache but I don't know when this code path is used.

@VReaperV

Copy link
Copy Markdown
Contributor

In which situation the remaining glVertexArrayElementBuffer() call can happen? It seems to be used in some GeometryCache but I don't know when this code path is used.

Only when material system is used.

@illwieckz

Copy link
Copy Markdown
Member

Excellent!

@illwieckz illwieckz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@illwieckz

Copy link
Copy Markdown
Member

I merge it because it makes easier to test other PRs.

@illwieckz
illwieckz merged commit 569e784 into DaemonEngine:master Aug 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It looks like glVertexArrayElementBuffer() is from OpenGL 4.5

3 participants