Skip to content

Fix dummyapp + Breakpad build #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slipher merged 2 commits into from
Aug 1, 2026
+1 −2
Merged

Fix dummyapp + Breakpad build #1999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0e0f86
Fix Linux dummyapp with Breakpad build
slipher Jul 31, 2026
feaa254
Remove a hack for old PCH implementation
slipher Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ if (USE_BREAKPAD)
add_library(srclibs-breakpad EXCLUDE_FROM_ALL ${BREAKPAD_LIST})
set_target_properties(srclibs-breakpad PROPERTIES POSITION_INDEPENDENT_CODE 1 FOLDER "libs")
target_compile_definitions(srclibs-breakpad PUBLIC HAVE_GETCONTEXT=1)
set(LIBS_ENGINE ${LIBS_ENGINE} srclibs-breakpad)
set(LIBS_ENGINE_BASE ${LIBS_ENGINE_BASE} srclibs-breakpad)

add_executable(crash_server src/engine/crash_server/crash_server_linux.cpp)
target_link_libraries(crash_server srclibs-breakpad)
Expand Down Expand Up @@ -894,7 +894,6 @@ if (NOT YOKAI_TARGET_SYSTEM_NACL)
AddApplication(
Target dummyapp
ExecutableName dummyapp
Definitions USELESS_DEFINITION_TO_AVOID_PCH_ISSUE
ApplicationMain ${ENGINE_DIR}/null/NullApplication.cpp
CompileFlags ${WARNINGS}
Files ${DUMMYAPPLIST}
Expand Down
Loading