Skip to content

polylib: workaround MAX_POINTS_ON_WINDING in ChopWindingInPlace, ref #169 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illwieckz merged 1 commit into from
Apr 13, 2020
Merged

polylib: workaround MAX_POINTS_ON_WINDING in ChopWindingInPlace, ref #169 #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/common/cm/cm_polylib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,14 @@ ChopWindingInPlace
*/
void ChopWindingInPlace( winding_t **inout, vec3_t normal, vec_t dist, vec_t epsilon )
{
// FIXME: https://github.com/DaemonEngine/Daemon/issues/169
// This is required to load oasis (Wolf:ET) and moteof (Q3) maps.
// Maps requiring this workaround are usually large and detailed maps
// but some very large maps do not require such workaround.
#define WORKAROUND_MAX_POINTS_ON_WINDING 4 * MAX_POINTS_ON_WINDING
winding_t *in;
vec_t dists[ MAX_POINTS_ON_WINDING + 4 ];
planeSide_t sides[ MAX_POINTS_ON_WINDING + 4 ];
vec_t dists[ WORKAROUND_MAX_POINTS_ON_WINDING + 4 ];
planeSide_t sides[ WORKAROUND_MAX_POINTS_ON_WINDING + 4 ];
int counts[ 3 ];
static vec_t dot; // VC 4.2 optimizer bug if not static
int i, j;
Expand Down Expand Up @@ -321,7 +326,12 @@ void ChopWindingInPlace( winding_t **inout, vec3_t normal, vec_t dist, vec_t eps

if ( f->numpoints > MAX_POINTS_ON_WINDING )
{
Sys::Drop( "ClipWinding: MAX_POINTS_ON_WINDING" );
Log::Debug( "ClipWinding: MAX_POINTS_ON_WINDING, %d > %d, please fix Daemon#169, applying workaround just for you", f->numpoints, MAX_POINTS_ON_WINDING );
}

if ( f->numpoints > WORKAROUND_MAX_POINTS_ON_WINDING )
{
Sys::Drop( "ClipWinding: MAX_POINTS_ON_WINDING, can't workaround more, %d > %d, maybe that's an issue on map side?", f->numpoints, WORKAROUND_MAX_POINTS_ON_WINDING );
}

FreeWinding( in );
Expand Down