Fix incompatible pointer type in Windows code (nacl_host_dir.c) - #29
Merged
Conversation
Fixes:
src/shared/platform/win/nacl_host_dir.c:43:30: error: passing argument 1 of 'FindFirstFileA' from incompatible pointer type [-Wincompatible-pointer-types]
43 | d->handle = FindFirstFile(d->pattern, &d->find_data);
| ~^~~~~~~~~
| |
| wchar_t * {aka short unsigned int *}
src/shared/platform/win/nacl_host_dir.c:220:34: error: passing argument 2 of 'FindNextFileA' from incompatible pointer type [-Wincompatible-pointer-types]
220 | if (!FindNextFile(d->handle, &d->find_data)) {
| ^~~~~~~~~~~~~
| |
| WIN32_FIND_DATAW *
Open
illwieckz
force-pushed
the
illwieckz/incompatible-pointers
branch
from
June 26, 2026 10:07
28fc8b3 to
241d782
Compare
Member
|
Probably a |
illwieckz
force-pushed
the
illwieckz/incompatible-pointers
branch
from
June 27, 2026 00:13
241d782 to
e9f8d4d
Compare
Member
Author
|
Thanks (the recent push is just me editing the commit message, no change to the patch). I caught some more: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
I reproduced it with MinGW from Debian 13.2 Trixie.
I didn't reproduced it with MinGW from Ubuntu 24.04.4 Noble.
I noticed it while working on implementing the NaCl loader build in Dæmon's external deps: