Skip to content

Add coverage and exclusions for dsm classes #11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarziali merged 1 commit into from
Jun 30, 2026
Merged

Add coverage and exclusions for dsm classes #11775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dd-trace-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ excludedClassesCoverage += [
'datadog.trace.core.TracingConfigPoller.Updater',
// covered with dd-trace-core/src/test/groovy/datadog/trace/core/datastreams/CheckpointerTest.groovy
'datadog.trace.core.datastreams.DefaultDataStreamsMonitoring',
// no-op
'datadog.trace.core.datastreams.DisabledDataStreamsMonitoring',
// pojo
'datadog.trace.core.datastreams.DataStreamsTransactionExtractors.DataStreamsTransactionExtractorImpl',
// it's a private inner class. Tested indirectly via deserialize in DataStreamsTransactionExtractorsTest
'datadog.trace.core.datastreams.DataStreamsTransactionExtractors.JsonDataStreamsTransactionExtractor',
// TODO CorePropagation will be removed during context refactoring
'datadog.trace.core.propagation.CorePropagation',
// TODO DSM propagator will be tested once fully migrated
Expand Down
64 changes: 64 additions & 0 deletions ...re/src/test/java/datadog/trace/core/datastreams/DataStreamsTransactionExtractorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

import static datadog.trace.api.datastreams.DataStreamsTransactionExtractor.Type.HTTP_IN_HEADERS;
import static datadog.trace.api.datastreams.DataStreamsTransactionExtractor.Type.HTTP_OUT_HEADERS;
import static datadog.trace.api.datastreams.DataStreamsTransactionExtractor.Type.KAFKA_CONSUME_HEADERS;
import static datadog.trace.api.datastreams.DataStreamsTransactionExtractor.Type.KAFKA_PRODUCE_HEADERS;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertSame;
import static org.junit.jupiter.api.Assertions.assertTrue;

import datadog.trace.api.datastreams.DataStreamsTransactionExtractor;
import datadog.trace.core.DDCoreJavaSpecification;
Expand All @@ -28,4 +32,64 @@ void deserializeFromJson() {
assertEquals(HTTP_IN_HEADERS, extractors.get(1).getType());
assertEquals("transaction_id", extractors.get(1).getValue());
}

@Test
void deserializeKafkaTypes() {
DataStreamsTransactionExtractors list =
DataStreamsTransactionExtractors.deserialize(
"["
+ "{\"name\": \"consume\", \"type\": \"KAFKA_CONSUME_HEADERS\", \"value\": \"txn\"},"
+ "{\"name\": \"produce\", \"type\": \"KAFKA_PRODUCE_HEADERS\", \"value\": \"txn\"}"
+ "]");
List<DataStreamsTransactionExtractor> extractors = list.getExtractors();

assertEquals(2, extractors.size());
assertEquals(KAFKA_CONSUME_HEADERS, extractors.get(0).getType());
assertEquals(KAFKA_PRODUCE_HEADERS, extractors.get(1).getType());
}

@Test
void deserializeUnknownTypeReturnsEmpty() {
DataStreamsTransactionExtractors list =
DataStreamsTransactionExtractors.deserialize(
"[{\"name\": \"ext\", \"type\": \"NOT_A_REAL_TYPE\", \"value\": \"v\"}]");

assertSame(DataStreamsTransactionExtractors.EMPTY, list);
assertTrue(list.getExtractors().isEmpty());
Comment thread
amarziali marked this conversation as resolved.
}

@Test
void deserializeEmptyArrayReturnsEmptyList() {
DataStreamsTransactionExtractors list = DataStreamsTransactionExtractors.deserialize("[]");

assertTrue(list.getExtractors().isEmpty());
}

@Test
void deserializeInvalidJsonReturnsEmpty() {
DataStreamsTransactionExtractors list =
DataStreamsTransactionExtractors.deserialize("not valid json");

assertSame(DataStreamsTransactionExtractors.EMPTY, list);
assertTrue(list.getExtractors().isEmpty());
}

@Test
void deserializeNullJsonReturnsEmpty() {
DataStreamsTransactionExtractors list = DataStreamsTransactionExtractors.deserialize("null");

assertTrue(list.getExtractors().isEmpty());
}

@Test
void implToStringContainsFields() {
DataStreamsTransactionExtractors list =
DataStreamsTransactionExtractors.deserialize(
"[{\"name\": \"myext\", \"type\": \"HTTP_OUT_HEADERS\", \"value\": \"myval\"}]");
String str = list.getExtractors().get(0).toString();

assertTrue(str.contains("myext"));
assertTrue(str.contains("HTTP_OUT_HEADERS"));
assertTrue(str.contains("myval"));
}
}
2 changes: 2 additions & 0 deletions internal-api/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ extra["excludedClassesCoverage"] = listOf(
"datadog.trace.api.profiling.RecordingType",
// Data Streams Monitoring
"datadog.trace.api.datastreams.Backlog",
"datadog.trace.api.datastreams.DataStreamsTransactionExtractor.Type", // enum
"datadog.trace.api.datastreams.InboxItem",
"datadog.trace.api.datastreams.KafkaConfigReport", // pojo
"datadog.trace.api.datastreams.NoopDataStreamsMonitoring",
"datadog.trace.api.datastreams.NoopPathwayContext",
"datadog.trace.api.datastreams.SchemaRegistryUsage",
Expand Down
Loading