Skip to content

Add missing coverage tests for Hashtable.D2 #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Jun 29, 2026
Merged

Add missing coverage tests for Hashtable.D2 #11779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27b0af8
Add missing coverage tests for Hashtable.D2
dougqh Jun 29, 2026
0c20744
Merge branch 'master' into dougqh/hashtable-d2-coverage-fix
dougqh Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal-api/src/test/java/datadog/trace/util/HashtableD2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,30 @@ void getOrCreateOnHitSkipsCreator() {
assertEquals(0, createCount[0]);
}

@Test
void removeReturnsNullForMissingKey() {
Hashtable.D2<String, Integer, PairEntry> table = new Hashtable.D2<>(8);
table.insert(new PairEntry("a", 1, 100));

assertNull(table.remove("a", 2));
assertNull(table.remove("z", 1));
assertEquals(1, table.size());
}

@Test
void clearEmptiesTable() {
Hashtable.D2<String, Integer, PairEntry> table = new Hashtable.D2<>(8);
table.insert(new PairEntry("a", 1, 100));
table.insert(new PairEntry("b", 2, 200));
assertEquals(2, table.size());

table.clear();

assertEquals(0, table.size());
assertNull(table.get("a", 1));
assertNull(table.get("b", 2));
}

private static final class PairEntry extends Hashtable.D2.Entry<String, Integer> {
int value;

Expand Down