Forward repository proxies to nested smoke test builds - #12150
Forward repository proxies to nested smoke test builds#12150AlexeyKuznetsov-DD wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
Proxy precedence, explicit nested property preservation, one-time init-script injection, and cache invalidation all remain consistent with the intended nested-build behavior. Focused plugin tests pass; the end-to-end scenarios could not complete because the sandbox cannot download Gradle 8.14.5, so that environment limitation is the remaining validation gap.
📊 Validated against 27 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit ee54d24 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
What Does This Do
Makes every
NestedGradleBuildinherit the outer build'smavenRepositoryProxyandgradlePluginProxysettings.When an effective proxy is configured, the task:
-Pproperty;gradleProperties;proxy-repositories.init.gradle.ktsexactly once, so nested builds do not need custom repository handling;Proxy resolution now lives entirely in
NestedGradleBuild. The previous CI-only forwarding inSmokeTestAppExtensionwas removed so manual and extension-created tasks use the same behavior and explicit task overrides work consistently.Motivation
Nested smoke-test builds use a temporary Gradle user home, so they cannot see proxy settings from the outer build's
gradle.properties.Previously, proxy forwarding lived in CI-only
SmokeTestAppExtensionconventions. Local builds therefore bypassed configured proxies, while the WildFlyearBuildtasks registered directly asNestedGradleBuildtasks did not receive the extension forwarding even on CI.This caused nested dependency resolution to fall back to Maven Central and fail in environments where direct access is blocked. Centralizing the behavior in the task also ensures future nested builds inherit proxy configuration automatically.
Additional Notes
Verification
SmokeTestAppPluginTest: 12 passed.SmokeTestAppEndToEndTestproxy regressions passed under JDK 21, covering:gradleProperties;./gradlew spotlessCheckpassed.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue🤖 Generated with Codex.