Pin apm-sdks-benchmarks and add tooling to automatically update pin - #12153
Conversation
…utomatically update pin
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
More details
The new updater correctly replaces all five pinned GitLab includes and the runtime clone SHA, rejects malformed commit inputs, and is idempotent when rerun. Workflow syntax parsed successfully and its token, checkout, commit-headless, and PR steps match existing repository automation; no concrete behavioral regression was identified.
📊 Validated against 7 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 761a752 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 761a752366
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, but I proposed optional improvement to use references like *apm_sdks_benchmarks_sha that will reduce future PRs to one line.
PerfectSlayer
left a comment
There was a problem hiding this comment.
👏 praise: Nice! Thanks for updating the workflow readme and crafting a nice PR from the update automation ✨
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Pin our
apm-sdks-benchmarksreference to the current latest commit SHA onmain. Add tooling to update this pinned SHA.Motivation
Currently, any change made to
apm-sdks-benchmarkswill take immediate effect in this repo. We should pin this reference to protect CI and releases.Additional Notes
The tooling automation will run once a week at the same frequency in which we update our gradle dependencies. It can also be manually triggered. The PR also goes in tandem with https://github.com/DataDog/apm-sdks-benchmarks/pull/228 (merged) which allows reading
apm-sdks-benchmarksrepo and https://github.com/DataDog/apm-sdks-benchmarks/pull/230 (waiting on review) which applies the logic to clone the repo at the specified SHA to thepost-pr-commentjob.Testing
The
tooling/update_apm_sdks_benchmarks_reference.shscript works locally, and the.github/workflows/update-apm-sdks-benchmarks-reference.yamlis based on existing working GitHub workflows. However, the workflow cannot be tested end-to-end until it lands onmasterbecause thedd-octo-stspermissions are scoped to and passed frommaster.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]