Skip to content

Pin apm-sdks-benchmarks and add tooling to automatically update pin - #12153

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
sarahchen6/pin-benchmarks
Aug 7, 2026
Merged

Pin apm-sdks-benchmarks and add tooling to automatically update pin#12153
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
sarahchen6/pin-benchmarks

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Pin our apm-sdks-benchmarks reference to the current latest commit SHA on main. Add tooling to update this pinned SHA.

Motivation

Currently, any change made to apm-sdks-benchmarks will take immediate effect in this repo. We should pin this reference to protect CI and releases.

Additional Notes

The tooling automation will run once a week at the same frequency in which we update our gradle dependencies. It can also be manually triggered. The PR also goes in tandem with https://github.com/DataDog/apm-sdks-benchmarks/pull/228 (merged) which allows reading apm-sdks-benchmarks repo and https://github.com/DataDog/apm-sdks-benchmarks/pull/230 (waiting on review) which applies the logic to clone the repo at the specified SHA to the post-pr-comment job.

Testing

The tooling/update_apm_sdks_benchmarks_reference.sh script works locally, and the .github/workflows/update-apm-sdks-benchmarks-reference.yaml is based on existing working GitHub workflows. However, the workflow cannot be tested end-to-end until it lands on master because the dd-octo-sts permissions are scoped to and passed from master.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Aug 5, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.92 s 13.99 s [-1.2%; +0.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.86 s 12.94 s [-1.2%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.38 s 17.05 s [+1.0%; +2.9%] (maybe worse)
startup:petclinic:iast:Agent 16.81 s 17.39 s [-7.6%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 17.24 s 17.30 s [-1.3%; +0.7%] (no difference)
startup:petclinic:sca:Agent 17.45 s 17.20 s [+0.3%; +2.5%] (maybe worse)
startup:petclinic:tracing:Agent 16.61 s 16.14 s [-1.4%; +7.2%] (no difference)

Commit: 7470e12b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-official

This comment has been minimized.

@sarahchen6
sarahchen6 marked this pull request as ready for review August 6, 2026 20:44
@sarahchen6
sarahchen6 requested review from a team as code owners August 6, 2026 20:44
@sarahchen6
sarahchen6 requested review from AlexeyKuznetsov-DD, PerfectSlayer and erikayasuda and removed request for a team August 6, 2026 20:44

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The new updater correctly replaces all five pinned GitLab includes and the runtime clone SHA, rejects malformed commit inputs, and is idempotent when rerun. Workflow syntax parsed successfully and its token, checkout, commit-headless, and PR steps match existing repository automation; no concrete behavioral regression was identified.

Was this helpful? React 👍 or 👎

📊 Validated against 7 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 761a752 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 761a752366

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/update-apm-sdks-benchmarks-reference.yaml

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I proposed optional improvement to use references like *apm_sdks_benchmarks_sha that will reduce future PRs to one line.

Comment thread .gitlab-ci.yml Outdated
Comment thread .gitlab-ci.yml Outdated
Comment thread tooling/update_apm_sdks_benchmarks_reference.sh Outdated

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Nice! Thanks for updating the workflow readme and crafting a nice PR from the update automation ✨

@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 18:14:12 UTC ℹ️ Start processing command /merge


2026-08-07 18:14:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-08-07 19:08:52 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit dda5452 into master Aug 7, 2026
593 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/pin-benchmarks branch August 7, 2026 19:08
@github-actions github-actions Bot added this to the 1.66.0 milestone Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants