utf-8 encoding fix & persister error logging#68
Merged
Conversation
Use UTF-8 encoding when writing to file in persister.py to fix encoding issues that occur when the default encoding is not UTF-8. This ensures that all characters are properly encoded and prevents errors when writing to the file.
There was a problem hiding this comment.
Pull request overview
This PR aims to improve cross-platform file output reliability by explicitly setting text encodings when persisting CSV/GeoJSON outputs, addressing Windows default-encoding UnicodeEncodeError issues.
Changes:
- Bumped package version from
0.10.2to0.10.3. - Added explicit encodings when writing CSV (
utf-8-sig) and GeoJSON (utf-8) output files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Version bump to 0.10.3. |
| backend/persister.py | Explicitly sets encodings for CSV/GeoJSON file writes to avoid platform-default encoding issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jacob-a-brown
changed the title
this preserves the original traceback, which is helpful for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
utf-8encoding, but Windows does not. This causesUnicodeEncodeErrorfor Windows usersHow
Implementation summary - the following was changed / added / removed:
utf-8encoding explicitly definedNotes
Any special considerations, workarounds, or follow-up work to note?