location_model_update_kas#122
Merged
Merged
Conversation
…apping styles for SQL Alchemy 2.0
…to reflect the use of proxies
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
reviewed
Sep 8, 2025
jirhiker
reviewed
Sep 8, 2025
jirhiker
requested changes
Sep 8, 2025
jirhiker
left a comment
Member
There was a problem hiding this comment.
tests failing. need to import UUID.
jirhiker
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
thing_associationsrelationship to the Location modelassociation_proxyfunction andAssociationProxyclass so proxies can be implementednma_pk_location,nma_notes_locationNotes
Any special considerations, workarounds, or follow-up work to note?
schemafiles were not updated. The only fields that were added were fields whose purpose is to preserve information from NMAquifer.testfiles have not been updated. I'm not sure if they need to be.Questions
- I think the Group model needs a relationship to the Location table. Thoughts?
- In the
schemas\location.pyfile, Should theeffective_startandeffective_endfields of theLocationThingAssociationbe included in the UPDATE schema?- I noticed the
Thingmodel uses theoverlapsrelationship attribute. Should this be used in theLocationmodel, too?- I assigned the
nma_pk_locationfield aMapped[UUID]type attribute. Shouldnma_pk_tablenamefields be assignedMapped[str]orMapped[UUID]type attributes? I think NMAquifer stored primary keys as GUIDs.