NO TICKET: cover all endpoints with auth dependencies#162
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
reviewed
Sep 30, 2025
jirhiker
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
user: <auth dependency>to every endpointNotes
Any special considerations, workarounds, or follow-up work to note?
userobject can be utilized. This will allow us in the future to return objects, likethingsorlocations, and hide some fields (e.g.notes), from unauthenticated users. To do this we'll need to set the viewer dependencies tooptional=True. But that's an issue for our future selves.ampauth dependencies or general dependencies. This is most pertinent to the/thing,/sample, and/observationrouters. Should they be general auth dependencies for now? Does it matter for the time being since everyone using the app is AMP?