Skip to content

NO TICKET: rename contact -> participant where appropriate#172

Merged
jirhiker merged 1 commit into
stagingfrom
jab-observation-field-revisions
Oct 3, 2025
Merged

NO TICKET: rename contact -> participant where appropriate#172
jirhiker merged 1 commit into
stagingfrom
jab-observation-field-revisions

Conversation

@jacob-a-brown

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • I forgot to update the fields after renaming FieldEventContactAssociation to FieldEventParticipant

How

Implementation summary - the following was changed / added / removed:

  • renamed field_contact_role --> participant_role
  • renamed mapped contact in FieldEventParticipant table --> participant

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Kept the name contact in the sample table

@codecov-commenter

codecov-commenter commented Oct 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
db/contact.py 100.00% <ø> (ø)
db/field.py 100.00% <100.00%> (ø)
db/sample.py 100.00% <ø> (ø)
services/sample_helper.py 100.00% <ø> (ø)
tests/conftest.py 100.00% <ø> (ø)

@jirhiker jirhiker merged commit c4cb7f0 into staging Oct 3, 2025
3 checks passed
Comment thread core/lexicon.json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add these roles to the role category that exists for Contacts, or is it better to have a separate category for participant_role?

@jacob-a-brown jacob-a-brown Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought to do that, but they kind of serve two different purposes. role describes the person (or organization) (e.g. Geologist, Biologist, Technician etc), whereas participant_role describes what role the person had in the field event (Lead, Participant, Observer etc). Trevor Kludt, for example, is a Technician, but during the field events he can be a Lead or a Participant

@TylerAdamMartinez TylerAdamMartinez deleted the jab-observation-field-revisions branch February 5, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants