NO TICKET: rename contact -> participant where appropriate#172
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
approved these changes
Oct 3, 2025
ksmuczynski
reviewed
Oct 3, 2025
Contributor
There was a problem hiding this comment.
Does it make sense to add these roles to the role category that exists for Contacts, or is it better to have a separate category for participant_role?
Contributor
Author
There was a problem hiding this comment.
At first I thought to do that, but they kind of serve two different purposes. role describes the person (or organization) (e.g. Geologist, Biologist, Technician etc), whereas participant_role describes what role the person had in the field event (Lead, Participant, Observer etc). Trevor Kludt, for example, is a Technician, but during the field events he can be a Lead or a Participant
ksmuczynski
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
FieldEventContactAssociationtoFieldEventParticipantHow
Implementation summary - the following was changed / added / removed:
field_contact_role-->participant_rolecontactinFieldEventParticipanttable -->participantNotes
Any special considerations, workarounds, or follow-up work to note?
contactin thesampletable