BDMS-221-225: Core well information model updates#239
Merged
ksmuczynski merged 6 commits intoNov 10, 2025
Conversation
Refactored Group model in db/group.py, adding the `group_type` and `monitoring_frequency` fields. Added new categories and terms to core/lexicon.json to support expanded group types and monitoring frequencies.
… StatusHistory table. `well_status` is defined as a lexicon category, but it should be a lexicon value associated with the `status_type` category. The `status_type` category does not exist, but it should. The terms assigned to the `well_status` category should actually be assigned to the `status_value` category. Renamed `well_status` category to `status_value`. Added new `status_type` category and related terms. Updated term definitions.
`Monitoring Status` should be a value/term associated with the `status_type` category, not a category unto itself. Removed the `monitoring_status` category and associated terms. Expanded terms associated with the `monitoring_frequency` category.
Comment on lines
+39
to
+42
| group_type: Mapped[Optional[str]] = mapped_column(String(50), nullable=True) | ||
| monitoring_frequency: Mapped[Optional[str]] = mapped_column( | ||
| String(50), nullable=True | ||
| ) |
Contributor
There was a problem hiding this comment.
these can be lexicon terms
Contributor
Author
There was a problem hiding this comment.
Good catch, thank you. The lexicon file should already be up to date.
`group_type` and `monitoring_frequency` fields should be lexicon terms. Updated `group_type` and `monitoring_frequency` fields to map to lexicon terms.
jacob-a-brown
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
GroupandStatusHIstorymodels.How
Implementation summary - the following was changed / added / removed:
group_typeandmonitoring_frequencyfields.well_statuscategory tostatus_value.status_typecategory and related terms.status_typeterm definitions.Notes
Any special considerations, workarounds, or follow-up work to note?