Skip to content

NO TICKET: only write to transfer logs for transfer scripts#243

Merged
jirhiker merged 1 commit into
stagingfrom
jab-transfer-logger-fix
Nov 12, 2025
Merged

NO TICKET: only write to transfer logs for transfer scripts#243
jirhiker merged 1 commit into
stagingfrom
jab-transfer-logger-fix

Conversation

@jacob-a-brown

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • the transfer logs should only be written to during transfer scripts, not during tests

How

Implementation summary - the following was changed / added / removed:

  • remove from transfers.transfers import erase_and_initalize from tests/__init__.py and use erase_and_rebuild_db from core/initializers.py instead. Otherwise the transfer logger will be instantiated and used for tests

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@codecov-commenter

codecov-commenter commented Nov 12, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
tests/__init__.py 83.33% <100.00%> (-16.67%) ⬇️

... and 16 files with indirect coverage changes

@jirhiker jirhiker merged commit a5c6b7d into staging Nov 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants