[NO TICKET] Update _get_groundwater_level_reason func#271
Closed
TylerAdamMartinez wants to merge 2 commits into
Closed
[NO TICKET] Update _get_groundwater_level_reason func#271TylerAdamMartinez wants to merge 2 commits into
TylerAdamMartinez wants to merge 2 commits into
Conversation
jacob-a-brown
left a comment
jacob-a-brown
left a comment
Contributor
There was a problem hiding this comment.
one minor comment - otherwise I think it looks good
|
|
||
| # If the mapper returns the raw key, it means "not mapped" | ||
| if mapped == lookup_key: | ||
| logger.warning(f"Unknown LevelStatus '{glv}', mapping to None") |
Contributor
There was a problem hiding this comment.
will you make this logger.critical?
Codecov Report✅ All modified and coverable lines are covered by tests. |
Member
|
this is being resolved in the latest transfer branch. There is an open PR to merge transfer into staging but im still trying to resolve issues |
Member
|
resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem/context:
How
Implementation summary - the following was changed/added/removed:
None.Notes
Any special considerations, workarounds, or follow-up work to note?