Skip to content

fix: prevent sorting of measuring points when none are available for water wells#274

Closed
jirhiker wants to merge 1 commit into
stagingfrom
hot-fix-staging
Closed

fix: prevent sorting of measuring points when none are available for water wells#274
jirhiker wants to merge 1 commit into
stagingfrom
hot-fix-staging

Conversation

@jirhiker

@jirhiker jirhiker commented Dec 5, 2025

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Use bullet points here

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@codecov-commenter

codecov-commenter commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
db/thing.py 97.93% <100.00%> (-2.07%) ⬇️

... and 24 files with indirect coverage changes

@jacob-a-brown

Copy link
Copy Markdown
Contributor

Measuring points are required for each well. Are we transferring some where that's not the case?

@jacob-a-brown

jacob-a-brown commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

It's a required field in CreateWell: https://github.com/DataIntegrationGroup/NMSampleLocations/blob/staging/schemas/thing.py#L133

Which is used to validate the incoming data: https://github.com/DataIntegrationGroup/NMSampleLocations/blob/staging/transfers/well_transfer.py#L343

I'll look to see if the MeasuringPointEstimator is setting it to None instead of raising an exception.

@jirhiker

jirhiker commented Dec 5, 2025

Copy link
Copy Markdown
Member Author

removed hack from transfer branch to insert wells with no measuring point

@jirhiker jirhiker closed this Dec 5, 2025
@jirhiker jirhiker deleted the hot-fix-staging branch March 12, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants