NO TICKET: update asset search#283
Merged
Merged
Conversation
Add the id to the asset search properties and update the things associated with assets to correspond with the things associated with contacts
jacob-a-brown
requested review from
TylerAdamMartinez,
chasetmartin,
jirhiker and
ksmuczynski
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the id to the asset search properties and update the things associated with assets to correspond with the things associated with contacts
Why
This PR addresses the following problem / context:
assetneeds itsidin the search response to be clickableHow
Implementation summary - the following was changed / added / removed:
idto the propertiesNotes
Any special considerations, workarounds, or follow-up work to note?
thingsto have thelabel,id, andthing_typeto correspond with a contact's associatedthingsin a search. @TylerAdamMartinez is that alright with you? Just returning an array of names enables you to display those names, but then they won't be usable.