BDMS 389: measuring notes refactor

[jacob-a-brown]

Why

This PR addresses the following problem / context:

• well-inventory-csv.feature has two fields to store notes about sampling scenario (water chemistry) and measurements (water levels). These need to be stored in the poymorphic notes table, but it was unclear where they should be stored. After discussions with @ksmuczynski and @chasetmartin we thought it'd be best for them to be stored as the same note type. We landed on the term Sampling Procedure as one that could encapsulate all sampling/measuring procedures, like water chemistry, water levels, geothermal, field parameters, etc

How

Implementation summary - the following was changed / added / removed:

• Measuring was changed to Sampling Procedure, which is where these notes will be stored. Other procedures, such as measuring field parameters, can also be stored here.

Notes

Any special considerations, workarounds, or follow-up work to note?

• This work does not effect the data transfer since no Measuring notes are being transferred.
• This PR is being opened into staging instead of well-inventory-csv to keep this refactor separate from its implementation. If/once it is approved I'll then merge that into well-inventory-csv and make the requisite updates
• @TylerAdamMartinez this should be a pretty minor change for the frontend. The biggest change is that the field in the WellResponse was changed from measuring_notes to sampling_procedure notes. We did talk about how AMP often uses sampling to refer to water chemistry sampling and measuring to refer to water level measurements. Perhaps the frontend can use a neutral term? Or is this a cultural shift that should occur at AMP?

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines	Coverage Δ
db/thing.py	97.94% <100.00%> (-0.03%)	⬇️
schemas/thing.py	95.19% <100.00%> (ø)