Skip to content

feat: add water level fields and scenario to well inventory feature #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirhiker merged 1 commit into from
Dec 10, 2025
Merged

feat: add water level fields and scenario to well inventory feature #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion tests/features/well-inventory-csv.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ Feature: Bulk upload well inventory from CSV
| well_purpose |
| well_hole_status |
| monitoring_frequency |
| sample_method |
| level_status |
| data_quality |

@positive @happy_path @BDMS-TBD
Scenario: Uploading a valid well inventory CSV containing required and optional fields
Expand Down Expand Up @@ -120,6 +123,15 @@ Feature: Bulk upload well inventory from CSV
| sampling_scenario_notes |
| well_measuring_notes |
| sample_possible |
And the csv includes optional water level entry fields when available:
| sampler |
| sample_method |
| measurement_date_time |
| mp_height |
Comment thread
jirhiker marked this conversation as resolved.
| level_status |
| depth_to_water_ft |
| data_quality |
| water_level_notes |
# And all optional lexicon fields contain valid lexicon values when provided
# And all optional numeric fields contain valid numeric values when provided
# And all optional date fields contain valid ISO 8601 timestamps when provided
Expand Down Expand Up @@ -449,4 +461,18 @@ Feature: Bulk upload well inventory from CSV
# Then the system returns a 422 Unprocessable Entity status code
# And the system should return a response in JSON format
# And the response includes a validation error indicating an invalid numeric format for "utm_easting"
# And no wells are imported
# And no wells are imported

###########################################################################
# WATER LEVEL ENTRY VALIDATIION
###########################################################################

# if one water level entry field is filled, then all are required
@negative @validation @BDMS-TBD
Scenario: Water level entry fields are all required if any are filled
Given my csv file contains a row where some but not all water level entry fields are filled
When I upload the file to the bulk upload endpoint
Then the system returns a 422 Unprocessable Entity status code
And the system should return a response in JSON format
And the response includes validation errors for each missing water level entry field
Comment thread
jirhiker marked this conversation as resolved.
And no wells are imported
Loading