Skip to content

NO TICKET: fix data types and validations date/time validations in the well inventory csv schema#294

Merged
jirhiker merged 3 commits into
well-inventory-csvfrom
datetime-validation-fix
Dec 12, 2025
Merged

NO TICKET: fix data types and validations date/time validations in the well inventory csv schema#294
jirhiker merged 3 commits into
well-inventory-csvfrom
datetime-validation-fix

Conversation

@jacob-a-brown

@jacob-a-brown jacob-a-brown commented Dec 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • Date and datetime values should not be in the future
  • mp_height should be a float if provided
  • depth_to_water_ft should be a float if provided

How

Implementation summary - the following was changed / added / removed:

  • Add after validators to ensure that future values are not submitted
  • Enable the function past_or_today to accept and evaluate both datetime and date objects
  • change mp_height to be a float
  • change depth_to_water to be a float
  • make date_drilled a date object, not datetime

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@jacob-a-brown
feat: ensure date/time values are today or in the past
9febedd 
This validation is important for maintaining data integrity in well
inventory records, preventing future dates from being erroneously
entered.
@jacob-a-brown
fix: require date_time field
9c7e635
@jacob-a-brown jacob-a-brown changed the title NO TICKET: fix date/time validations in the well inventory csv uploader NO TICKET: fix data types and validations date/time validations in the well inventory csv schema Dec 12, 2025
@jirhiker jirhiker merged commit 48dcb65 into well-inventory-csv Dec 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirhiker jirhiker jirhiker approved these changes
@ksmuczynski ksmuczynski Awaiting requested review from ksmuczynski
@chasetmartin chasetmartin Awaiting requested review from chasetmartin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacob-a-brown @jirhiker