Skip to content

NO TICKET: update water level feature field names #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chasetmartin merged 3 commits into from
Dec 17, 2025
Merged

NO TICKET: update water level feature field names #308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
232087c
feat: update csv template field names and add additional field staff
chasetmartin Dec 16, 2025
6b82f7e
fix: update field names in other occurences
chasetmartin Dec 16, 2025
256a6f9
fix: update water_level_date_time to be timezone naive and have backe…
chasetmartin Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions tests/features/water-level-csv.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Feature: Bulk upload water level entries from CSV via CLI
# And I have a valid CLI configuration for the target environment
# And valid lexicon values exist for:
# | lexicon category |
# | sampler |
# | sample_method |
# | level_status |
# | data_quality |
Expand All @@ -30,18 +29,20 @@ Feature: Bulk upload water level entries from CSV via CLI
| field_staff |
| well_name_point_id |
| field_event_date_time |
| measurement_date_time |
| sampler |
| water_level_date_time |
| measuring_person |
| sample_method |
| mp_height |
| level_status |
| depth_to_water_ft |
| data_quality |
And each "well_name_point_id" value matches an existing well
And "measurement_date_time" values are valid ISO 8601 timestamps with timezone offsets (e.g. "2025-02-15T10:30:00-08:00")
And "water_level_date_time" values are valid ISO 8601 timezone-naive datetime strings (e.g. "2025-02-15T10:30:00")
And the CSV includes optional fields when available:
| optional field name |
| water_level_notes |
| field_staff_2 |
| field_staff_3 |
| water_level_notes |
When I run the CLI command:
"""
oco water-levels bulk-upload --file ./water_levels.csv --output json
Expand All @@ -62,8 +63,8 @@ Feature: Bulk upload water level entries from CSV via CLI
And the CSV includes required fields:
| required field name |
| well_name_point_id |
| measurement_date_time |
| sampler |
| water_level_date_time |
| measuring_person |
| sample_method |
| mp_height |
| level_status |
Expand All @@ -73,7 +74,9 @@ Feature: Bulk upload water level entries from CSV via CLI
"""
oco water-levels bulk-upload --file ./water_levels.csv
"""
Then the command exits with code 0
# assumes users are entering datetimes as Mountain Time becuase well location is restricted to New Mexico
Then all datetime objects are assigned the correct Mountain Time timezone offset based on the date value.
And the command exits with code 0
And all water level entries are imported
And stderr should be empty

Expand Down Expand Up @@ -117,8 +120,8 @@ Feature: Bulk upload water level entries from CSV via CLI
Examples:
| required_field |
| well_name_point_id |
| measurement_date_time |
| sampler |
| water_level_date_time |
| measuring_person |
| sample_method |
| mp_height |
| level_status |
Expand All @@ -127,7 +130,7 @@ Feature: Bulk upload water level entries from CSV via CLI

@negative @validation @date_formats @BDMS-TBD
Scenario: Upload fails due to invalid date formats
Given my CSV file contains invalid ISO 8601 date values in the "measurement_date_time" field
Given my CSV file contains invalid ISO 8601 date values in the "water_level_date_time" field
When I run the CLI command:
"""
oco water-levels bulk-upload --file ./water_levels.csv
Expand All @@ -149,7 +152,7 @@ Feature: Bulk upload water level entries from CSV via CLI

@negative @validation @lexicon_values @BDMS-TBD
Scenario: Upload fails due to invalid lexicon values
Given my CSV file contains invalid lexicon values for "sampler", "sample_method", "level_status", or "data_quality"
Given my CSV file contains invalid lexicon values for "measuring_person", "sample_method", "level_status", or "data_quality"
When I run the CLI command:
"""
oco water-levels bulk-upload --file ./water_levels.csv
Expand Down
Loading