NO TICKET: enable user to submit tz-naive datetime objects #311
Merged
Conversation
…V tests This is no longer a requiremented of the incoming data and it will be handled by the API.
…DT data This ensures that the timezone offset being added to the datetime fields are being handled correctly
the users shouldn't need to care about the timezone or offsets being submitted. since we know that all incoming times are in Mountain Time the code now converts naive datetimes to timezone-aware datetimes assuming Mountain Time before further processing. The code handles MST and MDT as appropriate.
chasetmartin
approved these changes
Dec 18, 2025
chasetmartin
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me. It seems like if a future version of this well-inventory code is used to handle records sent individually from OcotilloUI (not from a csv), we'll have to circle back on the date/time format required.
Contributor
Author
|
That's definitely a good thing to keep in mind. Two things come to mind:
|
Member
|
I think for this case it's ok to assume that all datetimes will be in mountain time. However in general we should not assume all locations will be in New Mexico. Bureau researchers collect and analyze samples from all over Earth and even beyond. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
well-inventory-csv.featurethat were made in PR NO TICKET: Update well inventory csv feature field names #307:How
Implementation summary - the following was changed / added / removed:
ZoneInfolibraryNotes
Any special considerations, workarounds, or follow-up work to note?