BDMS 350: add groundwater_level_accuracy to observation model#314
Merged
Conversation
In NM_Aquifer these are strings describing the accuracy of the groundwater level measurement, so the field has been renamed from data_quality to groundwater_level_accuracy for clarity.
…vel_accuracy This is now included in both the creation and response of groundwater level observations.
jacob-a-brown
requested review from
Rachel-Hobbs,
chasetmartin,
jirhiker,
ksmuczynski and
marissafichera
jirhiker
requested changes
Dec 18, 2025
jirhiker
approved these changes
Dec 18, 2025
chasetmartin
approved these changes
Dec 18, 2025
chasetmartin
left a comment
chasetmartin
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, thanks for the clarification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
Ocotillowe need a way to track their accuracy, formerly known asDataQualityinNM_AquiferHow
Implementation summary - the following was changed / added / removed:
groundwater_level_accuracyinstead ofdata_qualitybecause every string describes the accuracy level. If, in the future, we want to change it into a numeric field we can certainly do thatgroundwater_level_accuracyto theobservationmodel and both theCreateGroundwaterLevelObservationandGroundwaterLevelObservationResponseschemasWaterLevels.DataQualitytoobservation.groundwater_level_accuradyNotes
Any special considerations, workarounds, or follow-up work to note?
data_qualityin the water level uploadwater-level-csvbecause that is where the work is needed. Eventually, when ready, we'll open a PR from that branch intostaging(then, as I wrote in Slack, this work will get applied to the well inventory csv upload if they contain water level data)