Skip to content

BDMS 350: water level csv feature test update #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacob-a-brown merged 5 commits into from
Jan 6, 2026
Merged

BDMS 350: water level csv feature test update #332

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
599fbb2
fix: remove measuring_person from lexicon tests
jacob-a-brown Jan 5, 2026
b634696
feat: add validation for measuring_person field in water level CSV up…
jacob-a-brown Jan 5, 2026
ed65e34
fix: remove erroneous well_references tag
jacob-a-brown Jan 5, 2026
260799e
refactor: use the word 'total' for all summaries
jacob-a-brown Jan 5, 2026
9c2668f
fix: add requisite steps for valid scenarios
jacob-a-brown Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions tests/features/water-level-csv.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,15 @@ Feature: Bulk upload water level entries from CSV via CLI
"""
oco water-levels bulk-upload --file ./water_levels.csv --output json
"""
Then the command exits with code 0
# assumes users are entering datetimes as Mountain Time becuase well location is restricted to New Mexico
Then all datetime objects are assigned the correct Mountain Time timezone offset based on the date value.
And the command exits with code 0
And stdout should be valid JSON
And stdout includes a summary containing:
| summary_field | value |
| total_rows_processed | 2 |
| total_rows_imported | 2 |
| validation_errors_or_warnings | 0 |
| total_validation_errors_or_warnings | 0 |
And stdout includes an array of created water level entry objects
And stderr should be empty

Expand All @@ -60,7 +62,9 @@ Feature: Bulk upload water level entries from CSV via CLI
Given my CSV file contains all required headers but in a different column order
And the CSV includes required fields:
| required field name |
| field_staff |
| well_name_point_id |
| field_event_date_time |
| water_level_date_time |
| measuring_person |
| sample_method |
Expand All @@ -85,7 +89,9 @@ Feature: Bulk upload water level entries from CSV via CLI
"""
oco water-levels bulk-upload --file ./water_levels.csv
"""
Then the command exits with code 0
# assumes users are entering datetimes as Mountain Time becuase well location is restricted to New Mexico
Then all datetime objects are assigned the correct Mountain Time timezone offset based on the date value.
And the command exits with code 0
And all water level entries are imported
And stderr should be empty

Expand Down Expand Up @@ -150,11 +156,22 @@ Feature: Bulk upload water level entries from CSV via CLI

@negative @validation @lexicon_values @BDMS-TBD
Scenario: Upload fails due to invalid lexicon values
Given my CSV file contains invalid lexicon values for "measuring_person", "sample_method", "level_status", or "data_quality"
Given my CSV file contains invalid lexicon values for "sample_method", "level_status", or "data_quality"
When I run the CLI command:
"""
oco water-levels bulk-upload --file ./water_levels.csv
"""
Then the command exits with a non-zero exit code
And stderr should contain validation errors identifying the invalid field and row
And no water level entries are imported

@negative @validation @BDMS-TBD
Scenario: Upload fails when "measuring_person" does not match "field_staff," "field_staff_2," or "field_staff_3"
Given my CSV file contains a "measuring_person" value that does not match any of the provided "field_staff" values
When I run the CLI command:
"""
oco water-levels bulk-upload --file ./water_levels.csv
"""
Then the command exits with a non-zero exit code
And stderr should contain a validation error for the "measuring_person" field
And no water level entries are imported
Loading