Skip to content

Implement backfill for legacy WaterLevelsContinuous_Pressure_Daily table #336

Merged
jirhiker merged 4 commits into
stagingfrom
migration/waterlevels-continuous-pressure-daily
Jan 7, 2026
Merged

Implement backfill for legacy WaterLevelsContinuous_Pressure_Daily table #336
jirhiker merged 4 commits into
stagingfrom
migration/waterlevels-continuous-pressure-daily

Conversation

@jirhiker

@jirhiker jirhiker commented Jan 7, 2026

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Need to store legacy daily pressure water level records in our schema.
  • Need a script to backfill those records from the existing CSV data source.

How

Implementation summary - the following was changed / added / removed:

  • Added Alembic migration b6c986eff2a8 to create the legacy NMA_WaterLevelsContinuous_Pressure_Daily table with all expected
    columns.
  • Added a backfill helper under transfers/backfill/ that loads the WaterLevelsContinuous_Pressure_Daily CSV, parses key dates,
    builds model instances, and bulk-inserts in batches via the Transferer flow, with a run(batch_size=...) entrypoint.

Notes

Any special considerations, workarounds, or follow-up work to note?

  • No automated tests were run; backfill and migration should be exercised in a suitable environment before deployment.

…ily table and make location.description nullable
@jirhiker jirhiker changed the title mplement backfill for legacy WaterLevelsContinuous_Pressure_Daily table and make location.description nullable Implement backfill for legacy WaterLevelsContinuous_Pressure_Daily table Jan 7, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bf5856c97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread transfers/backfill/waterlevelscontinuous_pressure_daily.py
@jirhiker

jirhiker commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jirhiker jirhiker merged commit 2d049bb into staging Jan 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant