Skip to content

feat: reorder Google Cloud authentication step in staging workflow#337

Merged
jirhiker merged 1 commit into
stagingfrom
migration/waterlevels-continuous-pressure-daily
Jan 7, 2026
Merged

feat: reorder Google Cloud authentication step in staging workflow#337
jirhiker merged 1 commit into
stagingfrom
migration/waterlevels-continuous-pressure-daily

Conversation

@jirhiker

@jirhiker jirhiker commented Jan 7, 2026

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Use bullet points here

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@jirhiker jirhiker merged commit f16d0b5 into staging Jan 7, 2026
5 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c2c255ca1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 35 to 37
- name: Run Alembic migrations on staging database
env:
DB_DRIVER: "cloudsql"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Authenticate before Cloud SQL migrations/backfill

The workflow now runs the Alembic migration (and the backfill step right after it) before google-github-actions/auth, but DB_DRIVER=cloudsql uses the Cloud SQL connector which relies on Application Default Credentials set by that auth step. On GitHub-hosted runners that don’t already have ADC configured, uv run alembic upgrade head and the backfill will fail to open a Cloud SQL connection. Unless these steps are intended to run without GCP auth, the auth step needs to stay before the Cloud SQL actions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant