-
Notifications
You must be signed in to change notification settings - Fork 4
BDMS-431; BDMS-437 #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
BDMS-431; BDMS-437 #346
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a1577da
feat: create legacy Chemistry_SampleInfo table and implement backfill…
jirhiker e3c7d3c
feat: add ChemistrySampleInfoAdmin view for legacy Chemistry_SampleIn…
jirhiker bc537db
feat: rename Chemistry_SampleInfo table to NMA_Chemistry_SampleInfo f…
jirhiker 51a10e8
feat: update boolean handling for ChemistrySampleInfo fields and adju…
jirhiker d8b88db
feat: enable backfill steps for WaterLevelsContinuous_Pressure_Daily …
jirhiker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| # =============================================================================== | ||
| # Copyright 2026 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # =============================================================================== | ||
| """ | ||
| ChemistrySampleInfoAdmin view for legacy Chemistry_SampleInfo. | ||
| """ | ||
| from admin.views.base import OcotilloModelView | ||
|
|
||
|
|
||
| class ChemistrySampleInfoAdmin(OcotilloModelView): | ||
| """ | ||
| Admin view for ChemistrySampleInfo model. | ||
| """ | ||
|
|
||
| # ========== Basic Configuration ========== | ||
|
|
||
| name = "Chemistry Sample Info" | ||
| label = "Chemistry Sample Info" | ||
| icon = "fa fa-flask" | ||
|
|
||
| # ========== List View ========== | ||
|
|
||
| column_list = [ | ||
| "object_id", | ||
| "sample_point_id", | ||
| "sample_pt_id", | ||
| "wclab_id", | ||
| "collection_date", | ||
| "sample_type", | ||
| "data_source", | ||
| "data_quality", | ||
| "public_release", | ||
| ] | ||
|
|
||
| column_sortable_list = [ | ||
| "object_id", | ||
| "sample_point_id", | ||
| "sample_pt_id", | ||
| "wclab_id", | ||
| "collection_date", | ||
| "sample_type", | ||
| "data_source", | ||
| "data_quality", | ||
| "public_release", | ||
| ] | ||
|
|
||
| column_default_sort = ("collection_date", True) | ||
|
|
||
| search_fields = [ | ||
| "sample_point_id", | ||
| "sample_pt_id", | ||
| "wclab_id", | ||
| "collected_by", | ||
| "analyses_agency", | ||
| "sample_notes", | ||
| ] | ||
|
|
||
| column_filters = [ | ||
| "collection_date", | ||
| "sample_type", | ||
| "sample_material_not_h2o", | ||
| "water_type", | ||
| "study_sample", | ||
| "data_source", | ||
| "data_quality", | ||
| "public_release", | ||
| ] | ||
|
|
||
| can_export = True | ||
| export_types = ["csv", "excel"] | ||
|
|
||
| page_size = 50 | ||
| page_size_options = [25, 50, 100, 200] | ||
|
|
||
| # ========== Form View ========== | ||
|
|
||
| fields = [ | ||
| "object_id", | ||
| "sample_point_id", | ||
| "sample_pt_id", | ||
| "wclab_id", | ||
| "collection_date", | ||
| "collection_method", | ||
| "collected_by", | ||
| "analyses_agency", | ||
| "sample_type", | ||
| "sample_material_not_h2o", | ||
| "water_type", | ||
| "study_sample", | ||
| "data_source", | ||
| "data_quality", | ||
| "public_release", | ||
| "added_day_to_date", | ||
| "added_month_day_to_date", | ||
| "sample_notes", | ||
| ] | ||
|
|
||
| exclude_fields_from_create = [ | ||
| "object_id", | ||
| ] | ||
|
|
||
| exclude_fields_from_edit = [ | ||
| "object_id", | ||
| ] | ||
|
|
||
| labels = { | ||
| "object_id": "OBJECTID", | ||
| "sample_point_id": "SamplePointID", | ||
| "sample_pt_id": "SamplePtID", | ||
| "wclab_id": "WCLab ID", | ||
| "collection_date": "Collection Date", | ||
| "collection_method": "Collection Method", | ||
| "collected_by": "Collected By", | ||
| "analyses_agency": "Analyses Agency", | ||
| "sample_type": "Sample Type", | ||
| "sample_material_not_h2o": "Sample Material Not H2O", | ||
| "water_type": "Water Type", | ||
| "study_sample": "Study Sample", | ||
| "data_source": "Data Source", | ||
| "data_quality": "Data Quality", | ||
| "public_release": "Public Release", | ||
| "added_day_to_date": "Added Day to Date", | ||
| "added_month_day_to_date": "Added Month Day to Date", | ||
| "sample_notes": "Sample Notes", | ||
| } | ||
|
|
||
|
|
||
| # ============= EOF ============================================= |
54 changes: 54 additions & 0 deletions
54
alembic/versions/b7d4c6a1b2c3_create_chemistry_sampleinfo.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| """Create legacy Chemistry_SampleInfo table. | ||
|
|
||
| Revision ID: b7d4c6a1b2c3 | ||
| Revises: 4b7aa74b15ad | ||
| Create Date: 2026-02-10 02:00:00.000000 | ||
| """ | ||
|
|
||
| from typing import Sequence, Union | ||
|
|
||
| from alembic import op | ||
| import sqlalchemy as sa | ||
| from sqlalchemy import inspect | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision: str = "b7d4c6a1b2c3" | ||
| down_revision: Union[str, Sequence[str], None] = "5f4e2b0a6b8b" | ||
| branch_labels: Union[str, Sequence[str], None] = None | ||
| depends_on: Union[str, Sequence[str], None] = None | ||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| """Create the legacy chemistry sample info table used for backfill.""" | ||
| bind = op.get_bind() | ||
| inspector = inspect(bind) | ||
| if not inspector.has_table("NMA_Chemistry_SampleInfo"): | ||
| op.create_table( | ||
| "NMA_Chemistry_SampleInfo", | ||
| sa.Column("OBJECTID", sa.Integer(), primary_key=True), | ||
| sa.Column("SamplePointID", sa.String(length=50), nullable=True), | ||
| sa.Column("SamplePtID", sa.String(length=50), nullable=True), | ||
| sa.Column("WCLab_ID", sa.String(length=50), nullable=True), | ||
| sa.Column("CollectionDate", sa.Date(), nullable=True), | ||
| sa.Column("CollectionMethod", sa.String(length=100), nullable=True), | ||
| sa.Column("CollectedBy", sa.String(length=100), nullable=True), | ||
| sa.Column("AnalysesAgency", sa.String(length=100), nullable=True), | ||
| sa.Column("SampleType", sa.String(length=100), nullable=True), | ||
| sa.Column("SampleMaterialNotH2O", sa.Boolean(), nullable=True), | ||
| sa.Column("WaterType", sa.String(length=100), nullable=True), | ||
| sa.Column("StudySample", sa.Boolean(), nullable=True), | ||
| sa.Column("DataSource", sa.String(length=100), nullable=True), | ||
| sa.Column("DataQuality", sa.String(length=100), nullable=True), | ||
| sa.Column("PublicRelease", sa.Boolean(), nullable=True), | ||
| sa.Column("AddedDaytoDate", sa.String(length=10), nullable=True), | ||
| sa.Column("AddedMonthDaytoDate", sa.String(length=10), nullable=True), | ||
| sa.Column("SampleNotes", sa.Text(), nullable=True), | ||
| ) | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| """Drop the legacy chemistry sample info table.""" | ||
| bind = op.get_bind() | ||
| inspector = inspect(bind) | ||
| if inspector.has_table("NMA_Chemistry_SampleInfo"): | ||
| op.drop_table("NMA_Chemistry_SampleInfo") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.