Skip to content

BDMS-453#349

Closed
jirhiker wants to merge 1 commit into
stagingfrom
BDMS-453-Migrate-Hydraulics-1-1
Closed

BDMS-453#349
jirhiker wants to merge 1 commit into
stagingfrom
BDMS-453-Migrate-Hydraulics-1-1

Conversation

@jirhiker

@jirhiker jirhiker commented Jan 8, 2026

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Add legacy HydraulicsData support for backfill workflows and admin visibility

How

Implementation summary - the following was changed / added / removed:

  • Added NMA_HydraulicsData legacy model in db/nma_legacy.py and corresponding Alembic migration
  • Implemented a HydraulicsData backfill script and wired it into transfers/backfill/staging.py
  • Added a read-only admin view for Hydraulics data and registered it in the admin config

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Backfill is idempotent via ON CONFLICT DO UPDATE on GlobalID

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71d6a96626

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +15 to +16
revision: str = "d1a2b3c4e5f6"
down_revision: Union[str, Sequence[str], None] = "c9f1d2e3a4b5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix missing Alembic down_revision

The migration declares down_revision as c9f1d2e3a4b5, but there is no corresponding revision file in alembic/versions, so the migration graph is disconnected and alembic upgrade head will fail to resolve this dependency. This blocks schema upgrades in any environment that runs migrations. Point down_revision at the current head revision (e.g., 5f4e2b0a6b8b) or add the missing revision.

Useful? React with 👍 / 👎.

@jirhiker jirhiker changed the title feat: add NMA_HydraulicsData model and admin view, including backfill functionality BDMS-453 Jan 8, 2026
@jirhiker

jirhiker commented Jan 8, 2026

Copy link
Copy Markdown
Member Author

there is no hydraulics data in the HydraulicsData table

@jirhiker jirhiker closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant