Skip to content

BDMS-455#350

Merged
jirhiker merged 3 commits into
stagingfrom
BDMS-455-Migrate-SurfaceWaterData
Jan 8, 2026
Merged

BDMS-455#350
jirhiker merged 3 commits into
stagingfrom
BDMS-455-Migrate-SurfaceWaterData

Conversation

@jirhiker

@jirhiker jirhiker commented Jan 8, 2026

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Introduce legacy SurfaceWaterData support for ingestion and admin visibility

How

Implementation summary - the following was changed / added / removed:

  • Added SurfaceWaterData legacy model in db/nma_legacy.py with UUID surface_id
  • Added Alembic migration to create NMA_SurfaceWaterData
  • Added SurfaceWaterData backfill script in transfers/backfill/surface_water_data.py
  • Added admin view for SurfaceWaterData and registered it in the admin config

Notes

Any special considerations, workarounds, or follow-up work to note?

  • If the table already exists, use alembic stamp 1680a4a7cb77 to align migration history

@jirhiker

jirhiker commented Jan 8, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad640ce0c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread transfers/backfill/surface_water_data.py
@jirhiker jirhiker merged commit f0436f8 into staging Jan 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant