Skip to content

BDMS-503: Implement read-only admin view for NMAMajorChemistry#432

Merged
chasetmartin merged 2 commits into
stagingfrom
kas-bdms-503-admin-view-NMAMajorChem
Jan 27, 2026
Merged

BDMS-503: Implement read-only admin view for NMAMajorChemistry#432
chasetmartin merged 2 commits into
stagingfrom
kas-bdms-503-admin-view-NMAMajorChem

Conversation

@ksmuczynski

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • Provide a read-only admin view for legacy NMA Major Chemistry records
  • Ensure the admin UI exposes all legacy columns with correct ordering and labels

How

Implementation summary - the following was changed / added / removed:

  • Added MajorChemistryAdmin view with read-only permissions, list/sort/search config, and labels
    • Included all model columns in list_fields and fields in legacy order, plus the HasOne parent link
    • Registered the new view in admin/views/init.py and admin/config.py

Notes

Any special considerations, workarounds, or follow-up work to note?

  • None noted

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a read-only admin view for the NMA_MajorChemistry model to provide visibility into legacy chemistry data through the admin interface.

Changes:

  • Added MajorChemistryAdmin class with read-only permissions and comprehensive field configuration
  • Registered the new admin view in the application's admin interface
  • Configured list display, sorting, searching capabilities, and field labels for all legacy columns

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
admin/views/major_chemistry.py New admin view implementation with read-only permissions, list/sort/search configuration, and field labels for NMA_MajorChemistry
admin/views/init.py Added MajorChemistryAdmin import and export
admin/config.py Registered MajorChemistryAdmin view and imported NMA_MajorChemistry model

Comment thread admin/views/major_chemistry.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 26, 2026 23:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@chasetmartin chasetmartin merged commit e5f8673 into staging Jan 27, 2026
6 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the kas-bdms-503-admin-view-NMAMajorChem branch February 5, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants