fix: added optional thing_id to the BaseAsset schema. fixed sample tests to use singleton asserts instead of asserting equal dictionaries#61
Merged
Conversation
…sts to use singleton asserts instead of asserting equal dictionaries
chasetmartin
approved these changes
Aug 4, 2025
chasetmartin
left a comment
chasetmartin
left a comment
Collaborator
There was a problem hiding this comment.
That's a much more graceful way to handle the create and update asset schemas.
Contributor
|
This looks good. @ksmuczynski and I worked on updating the sample database models, schemas, and tests as well. After this gets merged into pre-production I'll resolve merge conflicts and open a PR for the sample endpoint. |
jacob-a-brown
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?