[BDMS-123]: Add UTC normalization for date_time and measurement_date_time in well inventory importer#653
Merged
Merged
Conversation
… used it in well_inventory
jirhiker
approved these changes
Apr 17, 2026
Contributor
|
Looks great! The schema-level approach makes sense here. Just a few minor comments/suggestions, all optional.
|
ksmuczynski
approved these changes
Apr 17, 2026
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem/context:
measurement_date_timein the well inventory importer was not normalized to UTC before being written tosample.sample_dateandobservation.observation_datetimeHow
Implementation summary - the following was changed/added/removed:
normalize_datetime_to_utc()helper into a shared utility moduleWellInventoryRowschema validators:date_timeis now normalized to UTCmeasurement_date_timeis now normalized to UTCschemas/water_level_csv.pyto reuse the shared helper and keep validator behavior consistent (no intentional changes to water-level importer behavior)Notes
Any special considerations, workarounds, or follow-up work to note?