feat: add well counts and groups filter for projects view (BDMS-876)#722
Merged
Conversation
Groups list responses now include well counts, and the wells list can filter and sort by linked projects through the virtual groups field.
jeremyzilar
changed the title
Member
jirhiker
requested changes
Jun 15, 2026
| nlg = _linked_group_select(g.name.ilike(f"%{value}%")) | ||
| return sql.where(~exists(nlg)) | ||
|
|
||
| if operator == "contains": |
Member
There was a problem hiding this comment.
this functionality is duplicated in _linked_thing_select. consider moving to a separate function
…ry shape. _apply_thing_contacts_filter, _apply_thing_groups_filter, and _apply_contact_things_filter all defined the same inner function pattern: select(1).from(assoc).join(target).where(owner_fk, [extra], predicate). Extracted that pattern into a module-level _build_assoc_exists helper and replaced all three inner functions with calls to it. Behaviour is unchanged; the null/nnull unconditional checks pass no predicate (optional arg).
jirhiker
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
well_countto group list and GET responses for the Projects pagegroupsfilter and sort on the water-well list so wells can be scoped by projectTest plan
uv run pytest tests/test_group.py tests/test_thing.py -k "well_count or groups"/groupreturnswell_countper project/thing/water-well?filter=...filters by linked project id viagroups eqgroupsreturns 200Notes