feat(group): add thing-to-group association routes#729
Merged
Conversation
Supports the well edit panel in OcotilloUI (BDMS-879): POST and DELETE on /group/{group_id}/things/{thing_id} with 404/409 handling and audit on create.
jeremyzilar
requested review from
TylerAdamMartinez,
chasetmartin,
jirhiker and
likithabommasani21
11 tasks
jirhiker
requested changes
Jun 18, 2026
jirhiker
left a comment
jirhiker
left a comment
Member
There was a problem hiding this comment.
update PR title to use https://www.conventionalcommits.org/en/v1.0.0/
jeremyzilar
changed the title
Mirror the POST association route by forwarding the authenticated user into the helper and stamping updated_by before delete via audit_update.
jirhiker
approved these changes
Jun 22, 2026
likithabommasani21
approved these changes
Jun 22, 2026
jeremyzilar
added a commit
that referenced
this pull request
Jun 22, 2026
Combine PR #729 audit logging on group thing removal with BDMS-921 Slack edit notifications for project add/remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: DataIntegrationGroup/OcotilloUI#300
Summary
POST /group/{group_id}/things/{thing_id}to associate a well (thing) with a project (group), with audit logging and 409 when the link already existsDELETE /group/{group_id}/things/{thing_id}to remove that association, with 404 when it is missinggroup_helperservice functionsTest plan
POST /group/{group_id}/things/{thing_id}returns 201 and creates associationDELETE /group/{group_id}/things/{thing_id}returns 204 and removes association