Skip to content

[BDMS-242 and BDMS-239] Add notes to well details page#138

Merged
TylerAdamMartinez merged 9 commits into
stagingfrom
TAM-BDMS-242-AND-BDMS-239
Nov 21, 2025
Merged

[BDMS-242 and BDMS-239] Add notes to well details page#138
TylerAdamMartinez merged 9 commits into
stagingfrom
TAM-BDMS-242-AND-BDMS-239

Conversation

@TylerAdamMartinez

@TylerAdamMartinez TylerAdamMartinez commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem/context:

  • To fulfill requirements in tickets BDMS-242 and BDMS-239

How

Implementation summary - the following was changed/added/removed:

  • Add these fields to IThing
  water_notes?: string | null
  measuring_notes?: string | null
  notes?: string | null

Notes

Any special considerations, workarounds, or follow-up work to note?

Captura de pantalla 2025-11-19 a la(s) 10 17 33 Captura de pantalla 2025-11-19 a la(s) 10 24 55 Captura de pantalla 2025-11-19 a la(s) 10 25 27

@TylerAdamMartinez TylerAdamMartinez marked this pull request as ready for review November 17, 2025 20:21
@TylerAdamMartinez TylerAdamMartinez force-pushed the TAM-BDMS-242-AND-BDMS-239 branch from d5f8421 to f7c9904 Compare November 19, 2025 15:18
@chasetmartin

Copy link
Copy Markdown
Collaborator

@TylerAdamMartinez This is looking good. I think my only note is that I would lean towards having this accordion expanded by default, as users have noted the importance of being able to see notes quickly.

@TylerAdamMartinez TylerAdamMartinez requested review from chasetmartin and jirhiker and removed request for chasetmartin November 20, 2025 20:39

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one comment. Thanks for updating the contract tests.

Comment thread src/interfaces/ocotillo/IThing.ts
@jirhiker

Copy link
Copy Markdown
Member

lgtm

@TylerAdamMartinez TylerAdamMartinez merged commit 012178b into staging Nov 21, 2025
2 of 3 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the TAM-BDMS-242-AND-BDMS-239 branch November 21, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants