Fix selection/gesture bugs; add rhombus & clipboard paste (Ctrl/Cmd+V) - #14
Open
Dcode9 wants to merge 3 commits into
Open
Fix selection/gesture bugs; add rhombus & clipboard paste (Ctrl/Cmd+V)#14Dcode9 wants to merge 3 commits into
Dcode9 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
index.htmland cleaned up the modal promise handler.◇ Rhombus) so rhombus creation is discoverable.getStrokeLocalBoundsand a rotatedgetStrokeBounds, and updated selection overlay/handles to draw and snap correctly around rotated shapes (usesrotatePointAround/pointToStrokeLocal).copySelectedStrokesandpasteSelectedStrokes, wired them to the context menu and keyboard shortcuts (Ctrl/Cmd+C,Ctrl/Cmd+V), and ensure pasted objects are offset and selected.detectedToolPointerTypesset.exitSplitView()if already split, otherwise it creates a split as before.Testing
index.htmland rannode --checkon each extracted inline script; checks passed.node --checkon JS files includingassets/js/app.js,test.js, and API handlers; checks passed.git diff --checkto ensure no trailing whitespace/merge markers; check passed.python3 -m http.serverand fetchedindex.htmlviacurl -Iwhich returned HTTP 200 OK.Codex Task