Skip to content

Land the commit details pane as its own branch #14

Description

@Defmon3

Seen on: component/git-history

What it fixes

The History tab lists commits but cannot show one. This piece adds the commit details pane: full message, author and date, parents, and the paged list of changed files, shown beside the list on wide layouts and in a slide-over sheet on narrow ones, with a draggable divider between list and details.

Why we need it

It is PR 6 of the series in the Git History series issue (#8). It is the first piece with a second pane and a narrow layout, so the layout rules get reviewed here once, before the branches pane reuses them.

How to fix it

Cut a fresh branch on top of the History tab carrying the details pane, the resize handle, the narrow-layout sheet and header button, and their tests. The narrow-layout defect is fixed in this piece, so the header never goes inert without a sheet to close. The PR description states the end state from the series issue. Deferred: the diff view and the branches pane.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions