Git History fails for users who show commit signatures

[Defmon3]

Seen on: component/git-history

What it fixes

Anyone whose Git configuration shows commit signatures gets no Git History at all. Opening the History view fails on the server, and opening a single commit fails the same way. Nothing is shown except an error, and there is no fallback. People who sign their commits often have this setting on, so the feature is broken for exactly the users most likely to care about history.

How to fix it

When the server runs git to list commits or read one commit, it should tell git not to print signature verification output, so the record format the server parses stays machine-readable regardless of personal Git configuration. Ships with a test that runs git with signature display forced on. Nothing is deferred.

[Defmon3]

Technical appendix: Git History fails for users who show commit signatures

Investigated on branch component/git-history at commit 821fc7f.

Findings

• File apps/server/src/vcs/GitVcsDriverCore.ts, functions getHistory and getCommitDetails: both run git log and git show with a NUL-delimited --format record and parse the fields positionally in parseGitHistory and parseGitCommitDetails. Neither invocation passes --no-show-signature, and neither runs git with -c log.showSignature=false. Established by reading both functions.
• A grep for no-show-signature and showSignature over apps/ and packages/ returns no hits on the branch, so nothing else neutralizes the setting.
• Git runs with the server process environment (executeRaw in the same file spreads process.env into the child), so the user's global gitconfig applies.
• Reproduction, run on 2026-09-04 in this repository, which has GPG-signed commits at upstream/main:

$ git -c log.showSignature=true log -z --max-count=1 --format='%H%x00%s' upstream/main | head -c 120 | od -c
0000000   g   p   g   :       S   i   g   n   a   t   u   r   e       m
0000020   a   d   e       F   r   i       S   e   p           4       1
0000040   0   :   1   2   :   4   6       2   0   2   6       R   S   T
0000060  \n   g   p   g   :

$ git log -z --max-count=1 --format='%H%x00%s' upstream/main | head -c 50 | od -c
0000000   5   f   8   7   8   d   2   a   8   5   8   0   7   6   1   8

With the setting on, stdout begins with the gpg verification block, ahead of the hash. That text contains no NUL, so the first field of the record becomes the gpg text followed by the hash.

• parseGitHistory skips a record only when the hash field or the date field is empty, so the poisoned record is emitted. parseGitCommitDetails has the same guard.
• The result crosses the RPC boundary as VcsGetHistoryResult (file packages/contracts/src/git.ts), whose GitCommitHash requires 40 or 64 hex characters. Encoding fails, so the call errors instead of returning a partial list. Established by reading the schema; the end-to-end failure was not executed against a running server.
• Existing tests in apps/server/src/vcs/GitVcsDriverCore.test.ts exercise history parsing with plain git output only; none sets log.showSignature.

The problem

Observed: with log.showSignature = true in the user's Git configuration, the History view and the commit details pane fail on every repository that has signed commits.

Once fixed: that user sees the same history and commit details as a user without the setting, on every repository.