test(examples): guard the sidebar CV samples against a wrapped contact row - #615
Merged
DemchaAV merged 1 commit intoAug 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The two sidebar CV promotions each shipped with a wrapped contact row in the example preview: the email was wider than the sidebar's text column, so the row broke and left the envelope alone on the first line. Both promotions were green — 0-pixel parity against the published template, node-identical layout snapshots, both gates committed.
That is not a hole in the parity method; it is the edge of what it measures. The gates compare the port against the published template's own fixture, whose addresses fit by construction. The example sample data is written for the repository, is not part of any parity comparison, and can outgrow the column with every test still passing. It was spotted in a rendered preview, which is the one place it shows.
What changed
SidebarContactRowsFitTest— renders both CV samples and asserts everyContact_*row is a single line.Verification
Examples suite 77/77 → BUILD SUCCESS.
Fails closed, checked by restoring the address that caused it:
Contact_email (21.6pt)against the 14pt bound, naming the preset and the row. The addresses themselves were shortened in #614.Notes
Lane: test (examples) — no production code.