feat(templates): make the Navy Sidebar contact channels clickable - #616
Merged
DemchaAV merged 1 commit intoAug 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
NavySidebardrew its phone, email and LinkedIn as plain text, because the published template does — its data model has no href field at all, and the promotion kept it. Its siblingProfessionalSidebarmakes the same channels clickable, because that bundle carries the targets.So the same document rendered through the two sidebar CV presets gave a dialable phone in one and a dead one in the other, for no reason a reader could see. That is the wrong side of fidelity to be on: a CV is read on a screen.
What changed
tel:andmailto:built from the values, so the document does not carry the same address twice, and the link's own url for a profile. The address stays plain — there is nothing to open.Verification
Full reactor gate → BUILD SUCCESS; the preset's qa suite 11/11; examples suite 77/77 including
CommittedAssetDriftTestwith the re-rendered preview.The point worth checking is that this costs the port nothing, and both gates say so without being re-blessed:
That is the nature of the change: a link is an annotation beside the content stream, so it draws nothing and lays out nothing. The committed snapshot and pixel baseline were not touched; they simply still pass.
A new smoke case asserts the three targets, since a gate that cannot see the annotations is a gate that cannot protect them either.
Lane: canonical (templates.cv.presets + qa + examples) — no engine changes, no model changes.