Skip to content

feat(templates): make the Navy Sidebar contact channels clickable - #616

Merged
DemchaAV merged 1 commit into
feature/template-promotionfrom
feat/navy-sidebar-contact-links
Aug 30, 2026
Merged

DemchaAV merged 1 commit into
feature/template-promotionfrom
feat/navy-sidebar-contact-links

Conversation

@DemchaAV

Copy link
Copy Markdown
Owner

Why

NavySidebar drew its phone, email and LinkedIn as plain text, because the published template does — its data model has no href field at all, and the promotion kept it. Its sibling ProfessionalSidebar makes the same channels clickable, because that bundle carries the targets.

So the same document rendered through the two sidebar CV presets gave a dialable phone in one and a dead one in the other, for no reason a reader could see. That is the wrong side of fidelity to be on: a CV is read on a screen.

What changed

  • The Navy Sidebar phone, email and each identity link now carry a target: tel: and mailto: built from the values, so the document does not carry the same address twice, and the link's own url for a profile. The address stays plain — there is nothing to open.
  • The class documentation says so, replacing the paragraph that explained why they were not links.

Verification

Full reactor gate → BUILD SUCCESS; the preset's qa suite 11/11; examples suite 77/77 including CommittedAssetDriftTest with the re-rendered preview.

The point worth checking is that this costs the port nothing, and both gates say so without being re-blessed:

  • Parity against the published template's own render is still 0 / 2,173,720 differing pixels.
  • The layout snapshot is unchanged — 87 nodes before and after, zero rows differing on path or geometry.

That is the nature of the change: a link is an annotation beside the content stream, so it draws nothing and lays out nothing. The committed snapshot and pixel baseline were not touched; they simply still pass.

A new smoke case asserts the three targets, since a gate that cannot see the annotations is a gate that cannot protect them either.

Lane: canonical (templates.cv.presets + qa + examples) — no engine changes, no model changes.

@DemchaAV
DemchaAV merged commit 456e407 into feature/template-promotion Aug 30, 2026
12 checks passed
@DemchaAV
DemchaAV deleted the feat/navy-sidebar-contact-links branch August 30, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant