feat(templates): link SerifHeadline titles and keep its band columns off the rule - #620
Merged
DemchaAV merged 1 commit intoAug 31, 2026
Conversation
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three things the rendered sheet showed once it existed.
A project card wants to point somewhere — a repository, a case study — and nothing in the model could say so. A band column's text ran into the hairline beside it, because the published sheet lets it: a line that happens to fill its column touches the rule. And the packaged marks come in two colours, which nothing said, so the example mixed a navy project mark with a gold one and the row read as a mistake.
What changed
CvEntrycarries alink. A plain string, blank when absent, set throughCvEntry.Builder.link(...). Every titleSerifHeadlinedraws — a role, a project, a degree, an achievement — becomes a link when its entry carries one. The six-argument constructor is kept explicitly.GLYPH_CLEARANCE, the space the next column's mark already keeps on the other side, so the rule sits centred in white.cartandapiin the design's navy,trophy,chartandrocketin its gold — so a document picks one deliberately. The example now keeps its projects band to one colour and links both cards.Verification
Full reactor gate → BUILD SUCCESS; the serif and CV-data suites 21/21; examples suite 77/77 including
CommittedAssetDriftTestwith the re-rendered preview;javadoc:javadoc→ BUILD SUCCESS.This is the first place a promoted preset deliberately leaves the sheet it ports, so the departure is measured rather than described. Against the published template's own render, the fixture now differs by:
Both baselines were re-recorded with the change and nothing else moved — the working tree after the approve run shows only this preset's two files.
The link costs nothing by comparison: it is an annotation rather than ink, so it moves no pixel and no layout node. That is also why neither gate can protect it, and a smoke case asserts the three targets directly.
Notes
Lane: canonical (templates.cv.data + templates.cv.presets + qa + examples) — no engine changes.