chore(examples): drop the twin-output figures no page shows - #691
Merged
Merged
Conversation
The README's twin-output section, removed in #690, was the only place that showed assets/readme/twin-output-pdf.png, twin-output-pptx.png and twin-output-editing.png. No example renders them and no page links them; the drift guard's list of raster figures was the last thing keeping them. Delete the three figures (about 830 KB) together with their entries in CommittedAssetDriftTest.RASTER_FIGURES, which has to match the files beside the preview folder exactly. The Twin Output PDF and PPTX previews under assets/readme/examples stay, as does the example that renders them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
assets/readme/twin-output-pdf.png,twin-output-pptx.pngandtwin-output-editing.pngwere the figures of the README's twin-output section, which #690 removed. Nothing else uses them: no page links them and no example renders them. Their last reference wasCommittedAssetDriftTest.RASTER_FIGURES, the list of rasters the drift guard cannot compare. That list alone kept about 830 KB of unused images in the tree.What changed
RASTER_FIGURES.theOnlyAssetsThisCannotCompareAreTheOnesWrittenDownholds the files besideassets/readme/examplesequal to that list, so the folder and the list change together.assets/readme/examples,TwinOutputExampleand its layout snapshot are unchanged.Verification
./mvnw -B -ntp -f examples/pom.xml clean testreports BUILD SUCCESS: 87 tests, 0 failures, 0 skipped.CommittedAssetDriftTestrenders the whole catalogue and passes all three of its checks:RASTER_FIGURES.git grep -E 'twin-output-(pdf|pptx|editing)\.png'finds nothing.Lane: test. Removes three unused README assets and one test constant; no library code.