fix(cypher): apply distinct before return limits#906
Open
pcristin wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pcristin <xxxokzxxx@protonmail.com>
edeb189 to
417cd1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RETURN DISTINCTbeforeORDER BY,SKIP, andLIMITpost-processing.RETURN ... LIMITfast path only for non-DISTINCT, non-ordered returns.RETURN DISTINCTwithORDER BY/LIMIT,LIMITonly, andORDER BY/SKIP/LIMIT.Root Cause
RETURNrows were sorted and truncated before de-duplication. When duplicate projected rows appeared before the limit boundary, those duplicates consumed the limit and the finalDISTINCTpass returned too few rows.Test Plan
make -f Makefile.cbm build/c/test-runner./build/c/test-runner 2>&1 | awk '/=== cypher ===/{show=1} show{print} /cypher_parse_unwind_var/{exit}'git diff --check origin/main..HEADscripts/test.shpipeline.err phase=dumpfailures and an AddressSanitizer leak summary.scripts/lint.shclang-tidy,clang-format, andcppcheck.clang-tidyreports repository-wide warnings-as-errors outside this change.cppcheckreportssrc/pipeline/pass_pkgmap.c:421null-pointer warning and an internal AST error atinternal/cbm/extract_defs.c:3386.Notes
Fixes #873
Refs #594