Skip to content

fix: verify notification permission UX#469

Merged
jjoonleo merged 1 commit into
mainfrom
codexd/443-verify-notification-permission-ux
May 10, 2026
Merged

fix: verify notification permission UX#469
jjoonleo merged 1 commit into
mainfrom
codexd/443-verify-notification-permission-ux

Conversation

@jjoonleo

@jjoonleo jjoonleo commented May 9, 2026

Copy link
Copy Markdown
Contributor

Closes #443
References #465

Summary

  • Updates notification permission rationale and recovery copy to explicitly describe schedule preparation reminders in English and Korean.
  • Adds a small permission gateway around the notification allow screen so granted, denied, request, and settings-recovery paths can be widget-tested.
  • Adds [Release] Verify notification permission UX #443 implementation plan under plans/.

Verification

  • flutter pub get
  • flutter gen-l10n
  • dart run build_runner build --delete-conflicting-outputs (current build_runner reports this flag is ignored, generation completed)
  • dart format lib/presentation/notification_allow/screens/notification_allow_screen.dart lib/l10n/app_localizations.dart lib/l10n/app_localizations_en.dart lib/l10n/app_localizations_ko.dart test/presentation/notification_allow/notification_allow_screen_test.dart
  • flutter test test/presentation/notification_allow/notification_allow_screen_test.dart
  • flutter analyze
  • flutter test

Track impact

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 6812a91):

https://ontime-c63f1--pr469-codexd-443-verify-no-gfhrwo9l.web.app

(expires Sat, 16 May 2026 14:16:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 6812a91):

https://on-time-front-widgetbook--pr469-codexd-443-verify-no-nbelaoqp.web.app

(expires Sat, 16 May 2026 14:17:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e53128a376fed0209d449279de9c0d94c83cdd8b

@jjoonleo jjoonleo marked this pull request as ready for review May 10, 2026 02:59
@jjoonleo jjoonleo merged commit a3c8638 into main May 10, 2026
4 checks passed
@jjoonleo jjoonleo deleted the codexd/443-verify-notification-permission-ux branch May 10, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release] Verify notification permission UX

1 participant